Re: [PATCH v2 3/3] drm/xe/gt: Drop redundant forcewake

Rodrigo Vivi
2026-04-27T22:11:56Z

On Mon, Apr 27, 2026 at 02:59:28PM +0530, Raag Jadav wrote:
> xe_gt_suspend_prepare() doesn't perform any MMIO operation that requires
> forcewake in it's code path. Drop it.
>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>

it makes sense... for a moment I thought that the gsc work would require it,
but it has its own forcewake if needed...

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>$

> ---
> v2: Expand commit message (Rodrigo)
> ---
> drivers/gpu/drm/xe/xe_gt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
> index 3c031175f737..e5065f46c748 100644
> --- a/drivers/gpu/drm/xe/xe_gt.c
> +++ b/drivers/gpu/drm/xe/xe_gt.c
> @@ -1027,7 +1027,6 @@ void xe_gt_reset_async(struct xe_gt *gt)
>
> void xe_gt_suspend_prepare(struct xe_gt *gt)
> {
> - CLASS(xe_force_wake, fw_ref)(gt_to_fw(gt), XE_FORCEWAKE_ALL);
> xe_uc_suspend_prepare(&gt->uc);
> }
>
> --
> 2.43.0
>