From: "Tauro, Riana" <riana.tauro@intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: <intel-xe@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <netdev@vger.kernel.org>,
<simona.vetter@ffwll.ch>, <airlied@gmail.com>, <kuba@kernel.org>,
<lijo.lazar@amd.com>, <Hawking.Zhang@amd.com>,
<davem@davemloft.net>, <pabeni@redhat.com>, <edumazet@google.com>,
<dev@lankhorst.se>, <zachary.mckevitt@oss.qualcomm.com>,
<rodrigo.vivi@intel.com>, <michal.wajdeczko@intel.com>,
<matthew.d.roper@intel.com>, <mallesh.koujalagi@intel.com>
Subject: Re: [PATCH v3 3/4] drm/xe/ras: Add support for error threshold
Date: Wed, 17 Jun 2026 11:59:49 +0530 [thread overview]
Message-ID: <aeeeae06-e6d4-46e2-a188-38d1c09f1c51@intel.com> (raw)
In-Reply-To: <ajI-JwsLcVWoUiqj@black.igk.intel.com>
On 17-06-2026 11:56, Raag Jadav wrote:
> On Mon, Jun 15, 2026 at 01:47:02PM +0530, Tauro, Riana wrote:
>> On 05-06-2026 00:16, Raag Jadav wrote:
>>> System controller allows getting/setting per counter threshold, which it
>>> uses to raise error events to the driver. Get/set it using the respective
>>> mailbox command.
> ...
>
>>> + xe_dbg(xe, "[RAS]: get counter threshold %u for %s %s\n", *threshold,
>>> + comp_to_str(counter->common.component), sev_to_str(counter->common.severity));
>> "get threshold" to be consistent with <operation> <value> <component>
>> <severity>
>> and other prints
> I thought "counter threshold" was the correct[1] terminology?
>
> Raag
>
> [1] https://lore.kernel.org/intel-xe/ahgNW0Z9eQmQzGzY@black.igk.intel.com/
>
That should be fine. But keep all logs consistent.
The previous logs have get threshold
Thanks
Riana
next prev parent reply other threads:[~2026-06-17 6:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 18:46 [PATCH v3 0/4] Introduce error threshold to drm_ras Raag Jadav
2026-06-04 18:46 ` [PATCH v3 1/4] drm/ras: Introduce error threshold Raag Jadav
2026-06-15 8:56 ` Tauro, Riana
2026-06-17 6:19 ` Raag Jadav
2026-06-04 18:46 ` [PATCH v3 2/4] drm/xe/xe_ras: Add support for error counter Raag Jadav
2026-06-04 18:46 ` [PATCH v3 3/4] drm/xe/ras: Add support for error threshold Raag Jadav
2026-06-15 8:17 ` Tauro, Riana
2026-06-17 6:26 ` Raag Jadav
2026-06-17 6:29 ` Tauro, Riana [this message]
2026-06-04 18:46 ` [PATCH v3 4/4] drm/xe/drm_ras: Wire up error threshold callbacks Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeeeae06-e6d4-46e2-a188-38d1c09f1c51@intel.com \
--to=riana.tauro@intel.com \
--cc=Hawking.Zhang@amd.com \
--cc=airlied@gmail.com \
--cc=davem@davemloft.net \
--cc=dev@lankhorst.se \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=kuba@kernel.org \
--cc=lijo.lazar@amd.com \
--cc=mallesh.koujalagi@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=raag.jadav@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona.vetter@ffwll.ch \
--cc=zachary.mckevitt@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox