From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEA6FF9EDC5 for ; Wed, 22 Apr 2026 12:46:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B766710E2A9; Wed, 22 Apr 2026 12:46:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="OIuQPc+f"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id B7C3E10E2A9 for ; Wed, 22 Apr 2026 12:46:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776861981; x=1808397981; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=g5NoX4TVLCiPeCYOpr/LHCy4CGjH4btH+6dtSQk0wzA=; b=OIuQPc+flm+gzDAOF44hNEyhbEWICrkOdQSzCFTLLyRQ5muVtsELDT6N fdt9gyUwlfksdJz6YV3pl9aQltt62WkU22ANBxQJzbPuHBFeBoTdDSkFx +gv/sikgWQUB1E00DIskqOIO0Djc8vRKLkpfYPuzZG/qZoHnV8NapqaFs f4to/27vmZd6SIUlAE5qnTW2wJqnC7W1kL9LE2xV2t08vx91M6TmHIts5 eW4XKodXIbt6phbeOv9GS41F1S5hcKXpCCLdDMF2ATnGLbXgu1v+Vir3l B1iRonCCXjPOJdaxg0kNPzYpToRsB5GMbqGq1eLciORCTjWePM/ni5s6i g==; X-CSE-ConnectionGUID: usiN7Bu5Sd61eouostrRug== X-CSE-MsgGUID: YL8gGSY/TRyZuGLfeSXAzg== X-IronPort-AV: E=McAfee;i="6800,10657,11764"; a="88421720" X-IronPort-AV: E=Sophos;i="6.23,192,1770624000"; d="scan'208";a="88421720" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2026 05:46:20 -0700 X-CSE-ConnectionGUID: BFc3UItKSXytb1TFnrfveg== X-CSE-MsgGUID: n9/PnjiGQT6E39gRsXcSEQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,192,1770624000"; d="scan'208";a="236715954" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by orviesa004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2026 05:46:21 -0700 Received: from ORSMSX903.amr.corp.intel.com (10.22.229.25) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Wed, 22 Apr 2026 05:46:19 -0700 Received: from ORSEDG902.ED.cps.intel.com (10.7.248.12) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Wed, 22 Apr 2026 05:46:19 -0700 Received: from CY7PR03CU001.outbound.protection.outlook.com (40.93.198.68) by edgegateway.intel.com (134.134.137.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Wed, 22 Apr 2026 05:46:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RaDfQ46toexhHQeUXjQFI/V/LsbhYDJqfX9fUcxTazEumqOleW668ml6v3GSpwezpAblbGWg8//tpReVRFkvLJ7I5lO41yhM4KoAdOhlFn5QeW8i2cBQzHihEhFo37Kos6Vi7vvFblHhFWSAn3Qda+eyIEXFOa0J4zhunbf6iqHKkp3dp7WvCev6rUB/H3Xc6wFhTyK9cBmf6o2nt52AyruPTYSOrQsUB5SC9KCwj3LMqZ5nTz33YfuqWTeBKKz1mZSsLbazn4uKs/tx1TRLssEqGIYHKxygYLIsko7o1u5TgrKhg8D7aU/rdLqMRqKpejSKZW30sYUicKUNe0nbZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HbTDWkg8DyNufldo0/CGWOVa1lygIcigZc+aWbz8rL8=; b=Rovi6bkbAfYj8pTwJuDWzq2S3J/Uxmag1QS34/WZN0MLrzNCZUJVg/Tx1l4NBwCVQueDZir0QOJI2erxWe9/chgZo9BaJA7bq9xt8NUuwDtS2gVtHjWnLnp6YGTF80bR5aVPR274y0UJ0saJVd/eqIAAa5OFjasqfo2cW2SfeemHdkifN4mcICVzYbYD7pQZ2GNAT1mrDQSckChiLWIuuGE02fg+bn4EHPH/WPiaESX+etvXgsbDQP0PS+RdHcxw6IjEerK/f1Pf7rzD0vj9qC3oX0f2wyZ/5xO8elKPNNtX3Nhzo2YN8pAAtIr79yuNBiF3QkdKCVBm6GIHwZanOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CYYPR11MB8430.namprd11.prod.outlook.com (2603:10b6:930:c6::19) by PH7PR11MB8599.namprd11.prod.outlook.com (2603:10b6:510:2ff::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.16; Wed, 22 Apr 2026 12:46:10 +0000 Received: from CYYPR11MB8430.namprd11.prod.outlook.com ([fe80::1d86:a34:519a:3b0d]) by CYYPR11MB8430.namprd11.prod.outlook.com ([fe80::1d86:a34:519a:3b0d%5]) with mapi id 15.20.9846.019; Wed, 22 Apr 2026 12:46:09 +0000 Date: Wed, 22 Apr 2026 08:46:06 -0400 From: Rodrigo Vivi To: Raag Jadav CC: , , , Subject: Re: [PATCH v1 1/2] drm/xe/guc: Make xe_guc_pc_stop() void Message-ID: References: <20260422121128.1002031-1-raag.jadav@intel.com> <20260422121128.1002031-2-raag.jadav@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20260422121128.1002031-2-raag.jadav@intel.com> X-ClientProxiedBy: SJ2PR07CA0018.namprd07.prod.outlook.com (2603:10b6:a03:505::22) To CYYPR11MB8430.namprd11.prod.outlook.com (2603:10b6:930:c6::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CYYPR11MB8430:EE_|PH7PR11MB8599:EE_ X-MS-Office365-Filtering-Correlation-Id: 48f06d41-d3d5-4b33-90f7-08dea06d20b2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|366016|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: r9jQ5RRQ12r2JwaFjSZDuwCvh/L6eHTyMuUY/Pic0MGZRuJXu/MMuDyhbVWtSLDLimhaMPWZQHXflmQxWuiJZ+PLa7CMtYfLRkwHvuTnvOET4OmGjgwBeI/CiRaZh8Ss6/YKKpiY9N1bWVNubLI1BF8R1pQmloP8X5ODzyuGPXKFdbZgyt2u1vuzcleV9hDRbdBwB0nen836cyihQuf221vzdZcXGpc2fDck5dB1P6rDXWQDdmvrF35GB355DLjTkuugID+ohE0Uekub7iVyHAgnNJx6htOdlzdh38aYuhe7kPInXItJcSJ7+5YjR5FPgRiR4qj7SHYWXALWHJeC+mE5u9y079uPqIqeLeiyJoAZ7jFRXa5IpA34TQoZIqoBZUnUdEKh6HKwrkf+iMp/N8TxH4m6B3gX0BECEmBpmbY8dLR9MfrPb9BHGTxNf+ySOEjXcOantfBJN9Wxmitl6fRRMiUKyD9gRR+GiE7IWjUDPqPT5Ra5Cc3A1sQyQRNmo6e3gwE7Zw0k8GjJgG5T4PLccm+NMOfnarmvWNeAdpZNO2ww/YeqPEwJEww0y+aL9CMSxvkuTyZHcNLH8tOroXeFhm21wDK5VP5l44wvS4qUwt7UwTjGCNi6QLraaVDHTwE2xjHqahag/364h7TkEMslXRITiBkI19/y9ZbveuneXb6koD1XUn7j4++N8i1UW+X71WBE4dz7/Hls6zUr0jLnjj0ddkZ3g5vOrqGlbvM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CYYPR11MB8430.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(56012099003)(18002099003)(22082099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZEbLpIKgtrtmbfJCajKLKYwqvxOQ2xDoOJde4SUcWSltslPrl2SySLMRx98E?= =?us-ascii?Q?ObaKNiflUObsScS8Nrj6VflR7a6i607zUrO4WcNeJ/BT73+t5i0RnYlvf14q?= =?us-ascii?Q?GPiSZ39RSnTnVplHt6zURDh2+T8f2vatcwLnhCv3btrqvVIe/A6S4Flc6J67?= =?us-ascii?Q?CcO/L0KO0Fsz8l1OqTyUYC2Kp9+3EI/2kZxB86MUGwRInNy2qT4hl08QG+0x?= =?us-ascii?Q?591wifwHg9KC/yqTnchbOEbxs09pKkGkGb7kzydcKnbVFl0++dbmww+Dbq4y?= =?us-ascii?Q?HsfVIScMmCWgPzQ/HxeUs88K3CRfpBlczq58GXQqlIcr03tRSuzVpKqaqCY5?= =?us-ascii?Q?sv69N/plV/n4J/uKAAsnUJyiEhnI/j7oH/HboFCHcAAUCLVts4LVi8LgtZZi?= =?us-ascii?Q?m6as1+y0fugUKUWnG7mIxpyOvV4WYkwTBQIRr6EqvZBVdcbq4gzxTVn+KMFV?= =?us-ascii?Q?AqKSh9tK83YoobrwBQK3B4SF4iXW53ldeS4bHQq2d8TYN68Vy+XS344WhXz1?= =?us-ascii?Q?IahWtUOyuB9KMwbU94WXdWQeCuQ+3s0mMLa5FIT/r/wtPTOR76j/ITcQsuGs?= =?us-ascii?Q?TbfIoWgXRrOETOFb2+diXvWM/OuIzc5AZHcwrWB6gT7HStRvU9mWSouZdvcd?= =?us-ascii?Q?uvNESWMSB0YoFKNVLfSocOtART+neYYTyd4lNxwioLN3pTBTr1Eh72BGN2ZK?= =?us-ascii?Q?KGNp8v7mGq/ZN6QyCyw+TZ6ze3gEDqSRoOYgK+jazKMMGlG7cnbgBo+es69X?= =?us-ascii?Q?a1SsnsEUxykdFWJJOATgITX84KYLeZ4MzszfpzuPPIh8jjbNPuG3wd3wP8RP?= =?us-ascii?Q?4j9mEjn0U9S0Yh5Mn+wA/smX3G3+WYJKMTinL0aiM2jRiT+st2dF3sJnWfuR?= =?us-ascii?Q?eSmovq8DdWiXZXEXe+yKHk2AUVS/v81UPDIabgxi40euZKGKwgDugRXD87kW?= =?us-ascii?Q?jUzYlK2jOs1LlNOm+05PyKm1AA3vXCDyUcWCn5Io1IhDpfv6SUBnobFQG45+?= =?us-ascii?Q?2exPbPxVczNxwNhSDkmQIXg/b3Ei4Wpix4Cgc3eRHB2KkooLFMwhZmeDwrv+?= =?us-ascii?Q?u3Fp7uGvV0oBgvSbddLpG9jvBDGUU3dzPAlELnodWLqmQIO4u5R8FsHHEGYj?= =?us-ascii?Q?kfpBeNe9tjYuMmlY37Ey5oPkBdfVY3ou9NCpMIupmAyXmofTZBMFIrJXq00G?= =?us-ascii?Q?KtrYnShH/ewwjcV82YLBX9MAfvJVoCOjIE342+D+p8e8edSj+7F6bbQTllId?= =?us-ascii?Q?00pCoLhHa3k85sdJBFACaIO9iRegXb++jWUQW93FnCExP3IjSIYcIfRGqZga?= =?us-ascii?Q?8LNTrBhw5067c+bRoQkHewVc4gmXubNJGTuJuxMmvSvMltCviGdvZAreeKPh?= =?us-ascii?Q?ZEUgrvdiOE4cTIENPeRwALdEYaKhE5/HRGMbuZHRDlJg03U5cDO0ThT8ipR+?= =?us-ascii?Q?Ouzuf0ikg+zt1bLBA7e/YnCQLQ3fG/lo31QnfLf7VDK/Rjpcy1J/KZs0UDgt?= =?us-ascii?Q?0UZZuWts1eIdVUICjDPF/ZtGZKh8QsBsY4XgB9V6e+y37CoZ227FC83aOt/1?= =?us-ascii?Q?ZLXGKwZz1j+W/ddfcmeZX24zbH/qGi8lrIFVBeoDvJn8kI+biNNRL4FO/WM5?= =?us-ascii?Q?sCIh7eG2EqdVnZEzfo0ZzNh+KFqj0ve1m6WXXFuUCr8pneijddVri6EVrnOl?= =?us-ascii?Q?Wtr5+0TCFcoBAad7gr+uE9yN6tSqjnj7Roe9ocAOU9pv65vNaWZPvqg0jcFR?= =?us-ascii?Q?BdArEg9+gw=3D=3D?= X-Exchange-RoutingPolicyChecked: oXNidsZWT79jDh072Ya+IplHeSfRFJN5PaSow9VMH8TFJQEKgwhT+0OGAgoClbwkoJRM/LAHRGwsCVKmEo57FdZf89nfWFOfetn3jpgY7nJSgEOA8jQ1UdfCgmVdnoYDHehy5oFHM4wlz6uxffn8qeK99yYxwuV+upraa0veFiTeEnbQ3avH3UxQbRQWOtok1nN9+qeoLEQP+GbwL1l8hTfDOK6v1vk6iGzVXmrmL/yjHdExr8Qk9CJeeBv/FGXTJF2QKKotSgkf91DkmNzDxxy8qhrc/KBC1gz/gE7ubnv6lc7jgfmJGgx9+J2AfDbJuig7aCa3zjf3HT93NSBRWw== X-MS-Exchange-CrossTenant-Network-Message-Id: 48f06d41-d3d5-4b33-90f7-08dea06d20b2 X-MS-Exchange-CrossTenant-AuthSource: CYYPR11MB8430.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2026 12:46:09.7039 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LF1DokrHPEDmaF4cyL9IpFkr8wteWGwL7sCbOMagAVY4A0cTP9yKUWlE5dGozuoeT1FPcqcxtf5qxf/WK51TnQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8599 X-OriginatorOrg: intel.com X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, Apr 22, 2026 at 05:40:56PM +0530, Raag Jadav wrote: > xe_guc_pc_stop() doesn't return any meaningful value. Refactor it into > void function. > > Signed-off-by: Raag Jadav > --- > drivers/gpu/drm/xe/xe_guc.c | 9 ++------- > drivers/gpu/drm/xe/xe_guc_pc.c | 10 ++++------ > drivers/gpu/drm/xe/xe_guc_pc.h | 2 +- > 3 files changed, 7 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c > index 1355b68d3fce..ec291588c482 100644 > --- a/drivers/gpu/drm/xe/xe_guc.c > +++ b/drivers/gpu/drm/xe/xe_guc.c > @@ -1730,13 +1730,8 @@ void xe_guc_reset_wait(struct xe_guc *guc) > > void xe_guc_stop_prepare(struct xe_guc *guc) > { > - if (!IS_SRIOV_VF(guc_to_xe(guc))) { > - int err; > - > - err = xe_guc_pc_stop(&guc->pc); > - xe_gt_WARN(guc_to_gt(guc), err, "Failed to stop GuC PC: %pe\n", > - ERR_PTR(err)); > - } > + if (!IS_SRIOV_VF(guc_to_xe(guc))) > + xe_guc_pc_stop(&guc->pc); > } > > void xe_guc_stop(struct xe_guc *guc) > diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c > index 7ecd91ad6192..59f2fa79ad42 100644 > --- a/drivers/gpu/drm/xe/xe_guc_pc.c > +++ b/drivers/gpu/drm/xe/xe_guc_pc.c > @@ -1316,18 +1316,16 @@ int xe_guc_pc_start(struct xe_guc_pc *pc) > * xe_guc_pc_stop - Stop GuC's Power Conservation component > * @pc: Xe_GuC_PC instance > */ > -int xe_guc_pc_stop(struct xe_guc_pc *pc) > +void xe_guc_pc_stop(struct xe_guc_pc *pc) > { > struct xe_device *xe = pc_to_xe(pc); > > if (xe->info.skip_guc_pc) > - return 0; > + return; > > mutex_lock(&pc->freq_lock); > pc->freq_ready = false; > mutex_unlock(&pc->freq_lock); > - > - return 0; > } > > /** > @@ -1342,10 +1340,10 @@ static void xe_guc_pc_fini_hw(void *arg) > if (xe_device_wedged(xe)) > return; > > - CLASS(xe_force_wake, fw_ref)(gt_to_fw(pc_to_gt(pc)), XE_FW_GT); > - XE_WARN_ON(xe_guc_pc_stop(pc)); > + xe_guc_pc_stop(pc); > > /* Bind requested freq to mert_freq_cap before unload */ > + CLASS(xe_force_wake, fw_ref)(gt_to_fw(pc_to_gt(pc)), XE_FW_GT); this should be in a different patch. or at least with a good explanation on why on the commit message. but the rest of the patch is good... > pc_set_cur_freq(pc, min(pc_max_freq_cap(pc), xe_guc_pc_get_rpe_freq(pc))); > } > > diff --git a/drivers/gpu/drm/xe/xe_guc_pc.h b/drivers/gpu/drm/xe/xe_guc_pc.h > index 0678a4e787b3..1025a2b15f5f 100644 > --- a/drivers/gpu/drm/xe/xe_guc_pc.h > +++ b/drivers/gpu/drm/xe/xe_guc_pc.h > @@ -13,7 +13,7 @@ struct drm_printer; > > int xe_guc_pc_init(struct xe_guc_pc *pc); > int xe_guc_pc_start(struct xe_guc_pc *pc); > -int xe_guc_pc_stop(struct xe_guc_pc *pc); > +void xe_guc_pc_stop(struct xe_guc_pc *pc); > void xe_guc_pc_print(struct xe_guc_pc *pc, struct drm_printer *p); > int xe_guc_pc_action_set_param(struct xe_guc_pc *pc, u8 id, u32 value); > int xe_guc_pc_action_unset_param(struct xe_guc_pc *pc, u8 id); > -- > 2.43.0 >