Re: [PATCH v2] drm/i915/display: enable ccs modifiers on dg2

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Thu, Apr 23, 2026 at 05:11:48PM +0300, Juha-Pekka Heikkila wrote:
> Since Xe driver aux ccs enablement dg2 ccs modifiers have been
> disabled on both Xe and i915 drivers. Here allow dg2 to use
> ccs again for framebuffers.

I don't think they got disabled on xe since it just (for whatever
random reason) checks for ADL in its has_auxccs().

With the commit message sorted out this is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> 
> Fixes: 6a99e91a6ca8fec5882450128fb128265f86b32a ("drm/i915/display: Detect AuxCCS support via display parent interface")
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
>  drivers/gpu/drm/i915/i915_driver.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> index d31819758f3d..a4bd4f8e18b2 100644
> --- a/drivers/gpu/drm/i915/i915_driver.c
> +++ b/drivers/gpu/drm/i915/i915_driver.c
> @@ -750,9 +750,8 @@ static bool has_auxccs(struct drm_device *drm)
>  {
>  	struct drm_i915_private *i915 = to_i915(drm);
>  
> -	return IS_GRAPHICS_VER(i915, 9, 12) ||
> -	       IS_ALDERLAKE_P(i915) ||
> -	       IS_METEORLAKE(i915);
> +	return IS_GRAPHICS_VER(i915, 9, 12) &&
> +		!HAS_FLAT_CCS(i915);
>  }
>  
>  static bool has_fenced_regions(struct drm_device *drm)
> -- 
> 2.43.0

-- 
Ville Syrjälä
Intel