Re: [RFC 1/4] drm/xe/multi_queue: Remove redundant assignment in guc_exec_queue_run_job

[Matthew Brost <matthew.brost@intel.com>]

On Wed, Apr 22, 2026 at 07:49:53PM -0700, Niranjana Vishwanathapura wrote:
> The 'killed_or_banned_or_wedged = true' assignment is redundant
> since the variable is never read after that point.
> 
> Assisted-by: GitHub Copilot:claude-sonnet-4.6
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index b1222b42174c..104e65913dff 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -1216,10 +1216,8 @@ guc_exec_queue_run_job(struct drm_sched_job *drm_job)
>  		if (xe_exec_queue_is_multi_queue_secondary(q)) {
>  			struct xe_exec_queue *primary = xe_exec_queue_multi_queue_primary(q);
>  
> -			if (exec_queue_killed_or_banned_or_wedged(primary)) {
> -				killed_or_banned_or_wedged = true;
> +			if (exec_queue_killed_or_banned_or_wedged(primary))
>  				goto run_job_out;
> -			}
>  
>  			if (!exec_queue_registered(primary))
>  				register_exec_queue(primary, GUC_CONTEXT_NORMAL);
> -- 
> 2.43.0
>