Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Taylor, Clinton A" <clinton.a.taylor@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"Sousa,  Gustavo" <gustavo.sousa@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/xe3lpd: Load DMC
Date: Tue, 22 Oct 2024 17:43:52 +0000	[thread overview]
Message-ID: <af1f74e92773a150ce4e2ddc553ac00c415e4671.camel@intel.com> (raw)
In-Reply-To: <20241022155115.50989-1-gustavo.sousa@intel.com>

Reviewed-by: Clint Taylor <Clinton.A.Taylor@intel.com>

-Clint

On Tue, 2024-10-22 at 12:50 -0300, Gustavo Sousa wrote:
> Load the DMC for Xe3LPD.
> 
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dmc.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c
> b/drivers/gpu/drm/i915/display/intel_dmc.c
> index 48bbbf8f312c..5392b68627ae 100644
> --- a/drivers/gpu/drm/i915/display/intel_dmc.c
> +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> @@ -113,6 +113,9 @@ static bool dmc_firmware_param_disabled(struct intel_display
> *display)
>  #define DISPLAY_VER13_DMC_MAX_FW_SIZE	0x20000
>  #define DISPLAY_VER12_DMC_MAX_FW_SIZE	ICL_DMC_MAX_FW_SIZE
>  
> +#define XE3LPD_DMC_PATH			DMC_PATH(xe3lpd)
> +MODULE_FIRMWARE(XE3LPD_DMC_PATH);
> +
>  #define XE2LPD_DMC_PATH			DMC_PATH(xe2lpd)
>  MODULE_FIRMWARE(XE2LPD_DMC_PATH);
>  
> @@ -168,7 +171,10 @@ static const char *dmc_firmware_default(struct intel_display
> *display, u32 *size
>  	const char *fw_path = NULL;
>  	u32 max_fw_size = 0;
>  
> -	if (DISPLAY_VER_FULL(display) == IP_VER(20, 0)) {
> +	if (DISPLAY_VER_FULL(display) == IP_VER(30, 0)) {
> +		fw_path = XE3LPD_DMC_PATH;
> +		max_fw_size = XE2LPD_DMC_MAX_FW_SIZE;
> +	} else if (DISPLAY_VER_FULL(display) == IP_VER(20, 0)) {
>  		fw_path = XE2LPD_DMC_PATH;
>  		max_fw_size = XE2LPD_DMC_MAX_FW_SIZE;
>  	} else if (DISPLAY_VER_FULL(display) == IP_VER(14, 1)) {

  parent reply	other threads:[~2024-10-22 17:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-22 15:50 [PATCH] drm/i915/xe3lpd: Load DMC Gustavo Sousa
2024-10-22 16:16 ` ✓ CI.Patch_applied: success for " Patchwork
2024-10-22 16:16 ` ✓ CI.checkpatch: " Patchwork
2024-10-22 16:17 ` ✓ CI.KUnit: " Patchwork
2024-10-22 16:29 ` ✓ CI.Build: " Patchwork
2024-10-22 16:31 ` ✓ CI.Hooks: " Patchwork
2024-10-22 16:33 ` ✗ CI.checksparse: warning " Patchwork
2024-10-22 16:51 ` ✓ CI.BAT: success " Patchwork
2024-10-22 17:43 ` Taylor, Clinton A [this message]
2024-10-25 20:13   ` [PATCH] " Gustavo Sousa
2024-10-22 19:39 ` ✗ CI.FULL: failure for " Patchwork
2024-10-25 19:34   ` Gustavo Sousa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af1f74e92773a150ce4e2ddc553ac00c415e4671.camel@intel.com \
    --to=clinton.a.taylor@intel.com \
    --cc=gustavo.sousa@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox