Re: [PATCH] drm/xe/ggtt: Remove duplicate XE_GGTT_FLAGS_64K macro definition

["Bai, Zongyao" <zongyao.bai@intel.com>]

LGTM

Reviewed-by:  Zongyao Bai

On 3/16/2026 3:27 PM, Shuicheng Lin wrote:
> XE_GGTT_FLAGS_64K is defined twice in xe_ggtt.c: once at file scope
> (alongside XE_GGTT_FLAGS_ONLINE) and once inside struct xe_ggtt. The
> duplicate inside the struct was originally the only definition when the
> struct lived in xe_ggtt_types.h, but when commit 4f3a998a173b ("drm/xe:
> Open-code GGTT MMIO access protection") added the file-scope definitions
> for both FLAGS_64K and FLAGS_ONLINE, it did not remove the pre-existing
> one inside the struct.
>
> Remove the redundant definition inside struct xe_ggtt, keeping only the
> file-scope pair at the top of the file.
>
> Fixes: 4f3a998a173b ("drm/xe: Open-code GGTT MMIO access protection")
> Cc: Matthew Brost <matthew.brost@intel.com>
> Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_ggtt.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c
> index 21071b64b09d..68d54ddfcdb1 100644
> --- a/drivers/gpu/drm/xe/xe_ggtt.c
> +++ b/drivers/gpu/drm/xe/xe_ggtt.c
> @@ -115,7 +115,6 @@ struct xe_ggtt {
>   	/** @size: Total usable size of this GGTT */
>   	u64 size;
>   
> -#define XE_GGTT_FLAGS_64K BIT(0)
>   	/**
>   	 * @flags: Flags for this GGTT
>   	 * Acceptable flags: