From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87430FF8873 for ; Tue, 28 Apr 2026 09:55:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2C1A110EACA; Tue, 28 Apr 2026 09:55:18 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="RT5cRL60"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id C3F2910EAC6; Tue, 28 Apr 2026 09:55:16 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 8CF1F43E2C; Tue, 28 Apr 2026 09:55:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9F56C2BCAF; Tue, 28 Apr 2026 09:55:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777370116; bh=lY/rML6uz9ZIxs4GZnCj1Fq5sJipTf0WSkf6XsU+5fQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RT5cRL60PRur02Ka7Bt2xPa173aOEsxKJHzEsAiNqLrmc1L5JfzjJEeSh0Mby5UHu AzD+yW3MnM2lyhaFyLtxmnKyELftaxVn+DO+yVHeJhQclTHJ+lr1TjLae2xsMlZURE WohT37zr6awZujlqOw8imG40dKFKE22c6lPAESQIKH2IsXc07MoMG9gdOwgx5lRwrr pQNrOXELlyhnUsMNhwAyF6xkxwlqIufvRmsMjUFCyxrlkbixLV+23o0LECPKaX8FlG qo78jBZfYukijVqKqI5RmdvX6RZi4mwgvretNOTakXN2MmXmHhPIZCNszrsusyR0dM NaUd9ZeokEpIw== Date: Tue, 28 Apr 2026 11:55:12 +0200 From: Andi Shyti To: Matthew Brost Cc: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Tvrtko Ursulin , Thomas =?utf-8?Q?Hellstr=C3=B6m?= , Carlos Santa , Christian Koenig , Huang Rui , Matthew Auld , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Daniel Colascione Subject: Re: [PATCH v2 2/5] drm/ttm: Issue direct reclaim at beneficial_order Message-ID: References: <20260423055656.1696379-1-matthew.brost@intel.com> <20260423055656.1696379-3-matthew.brost@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260423055656.1696379-3-matthew.brost@intel.com> X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Hi Matt, On Wed, Apr 22, 2026 at 10:56:53PM -0700, Matthew Brost wrote: > Triggering kswap at an order higher than beneficial_order makes little > sense, as the driver has already indicated the optimal order at which > reclaim is effective. Similarly, issuing direct reclaim or triggering > kswap at a lower order than beneficial_order is ineffective, since the > driver does not benefit from reclaiming lower-order pages. > > As a result, direct reclaim should only be issued with __GFP_NORETRY at > exactly beneficial_order, or as a fallback, direct reclaim without > __GFP_NORETRY at order 0 when failure is not an option. > > Cc: Tvrtko Ursulin > Cc: Thomas Hellström > Cc: Carlos Santa > Cc: Christian Koenig > Cc: Huang Rui > Cc: Matthew Auld > Cc: Matthew Brost > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Simona Vetter > CC: dri-devel@lists.freedesktop.org > Cc: Daniel Colascione > Signed-off-by: Matthew Brost > Reviewed-by: Christian Koenig Reviewed-by: Andi Shyti Thanks, Andi