public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@kernel.org>
To: "Tauro, Riana" <riana.tauro@intel.com>
Cc: Soham Purkait <soham.purkait@intel.com>,
	 intel-xe@lists.freedesktop.org, anshuman.gupta@intel.com,
	aravind.iddamsetty@linux.intel.com,  badal.nilawar@intel.com,
	raag.jadav@intel.com, ravi.kishore.koppuravuri@intel.com,
	 mallesh.koujalagi@intel.com, andi.shyti@intel.com,
	rodrigo.vivi@intel.com,  anoop.c.vijay@intel.com
Subject: Re: [PATCH v2 2/2] drm/xe/xe_ras: Add RAS support for GPU health indicator
Date: Tue, 28 Apr 2026 14:57:11 +0200	[thread overview]
Message-ID: <afCuTKxpGWoeJSC2@zenone.zhora.eu> (raw)
In-Reply-To: <f9b1624f-543a-45dd-ad02-6a656999a1e3@intel.com>

Hi Riana,

> > +/**
> > + * xe_ras_init - Initialize Xe RAS
> > + * @xe: xe device instance
> > + *
> > + * Initialize Xe RAS
> > + */
> > +void xe_ras_init(struct xe_device *xe)
> > +{
> > +	int ret;
> > +
> > +	if (!xe->info.has_sysctrl)
> > +		return;
> > +
> > +	ret = gpu_health_indicator_sysfs_init(xe);
> > +	if (ret)
> > +		xe_err(xe, "[RAS]: failed to initialize GPU health sysfs, err=%d\n", ret);
> 
> Should we fail probe here?

No. If the driver is still working why should we fail probe on
purpose?

Andi

  reply	other threads:[~2026-04-28 12:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-23 17:39 [PATCH v2 0/2] drm/xe: Add support for GPU health indicator Soham Purkait
2026-04-23 17:39 ` [PATCH v2 1/2] drm/xe/xe_ras: Add types and commands for RAS " Soham Purkait
2026-04-28  8:56   ` Tauro, Riana
2026-04-29  5:24     ` Purkait, Soham
2026-04-29  5:34       ` Raag Jadav
2026-04-28 13:19   ` Andi Shyti
2026-04-23 17:39 ` [PATCH v2 2/2] drm/xe/xe_ras: Add RAS support for " Soham Purkait
2026-04-27 22:16   ` Rodrigo Vivi
2026-04-28  8:24   ` Tauro, Riana
2026-04-28 12:57     ` Andi Shyti [this message]
2026-04-29  6:07     ` Purkait, Soham
2026-04-28 13:47   ` Andi Shyti
2026-04-29  5:39   ` Raag Jadav
2026-04-23 17:52 ` ✗ CI.checkpatch: warning for drm/xe: Add " Patchwork
2026-04-23 17:54 ` ✓ CI.KUnit: success " Patchwork
2026-04-23 19:02 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-24  2:52 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afCuTKxpGWoeJSC2@zenone.zhora.eu \
    --to=andi.shyti@kernel.org \
    --cc=andi.shyti@intel.com \
    --cc=anoop.c.vijay@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=aravind.iddamsetty@linux.intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=mallesh.koujalagi@intel.com \
    --cc=raag.jadav@intel.com \
    --cc=ravi.kishore.koppuravuri@intel.com \
    --cc=riana.tauro@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=soham.purkait@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox