Re: [PATCH] drm/xe: Use drmm_mutex_init for VRAM manager lock

[Matthew Brost <matthew.brost@intel.com>]

On Wed, Apr 29, 2026 at 03:01:39PM +0530, Tejas Upadhyay wrote:
> Replace mutex_init()/mutex_destroy() with drmm_mutex_init() for the
> VRAM manager lock. This leverages DRM managed infrastructure to
> automatically destroy the mutex during device teardown, eliminating
> manual mutex_destroy() calls in both the normal fini path and the
> gpu_buddy_init() error path.
> 
> Assisted-by: Claude:claude-opus-4.6
> Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_ttm_vram_mgr.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c b/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
> index 5fd0d5506a7e..6ba47996bc7c 100644
> --- a/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
> +++ b/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
> @@ -292,8 +292,6 @@ static void xe_ttm_vram_mgr_fini(struct drm_device *dev, void *arg)
>  	ttm_resource_manager_cleanup(&mgr->manager);
>  
>  	ttm_set_driver_manager(&xe->ttm, mgr->mem_type, NULL);
> -
> -	mutex_destroy(&mgr->lock);
>  }
>  
>  int __xe_ttm_vram_mgr_init(struct xe_device *xe, struct xe_ttm_vram_mgr *mgr,
> @@ -312,7 +310,9 @@ int __xe_ttm_vram_mgr_init(struct xe_device *xe, struct xe_ttm_vram_mgr *mgr,
>  
>  	man->func = &xe_ttm_vram_mgr_func;
>  	mgr->mem_type = mem_type;
> -	mutex_init(&mgr->lock);
> +	err = drmm_mutex_init(&xe->drm, &mgr->lock);
> +	if (err)
> +		return err;
>  	mgr->default_page_size = default_page_size;
>  	mgr->visible_size = io_size;
>  	mgr->visible_avail = io_size;
> -- 
> 2.52.0
>