public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: Dave Airlie <airlied@gmail.com>
Cc: Kenneth Crudup <kenny@panix.com>,
	<intel-xe@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>,
	Christian Koenig <christian.koenig@amd.com>,
	Huang Rui <ray.huang@amd.com>,
	Matthew Auld <matthew.auld@intel.com>
Subject: Re: [PATCH v2] drm/ttm: Fix GPU MM stats during pool shrinking
Date: Sun, 3 May 2026 21:09:31 -0700	[thread overview]
Message-ID: <afgb+7p7ecnMGNQL@gsse-cloud1.jf.intel.com> (raw)
In-Reply-To: <CAPM=9txfkvL4pWW53Pk0OtJ=vBaa-SCv6npSCK5f0zuOOJUfSQ@mail.gmail.com>

On Mon, May 04, 2026 at 01:56:25PM +1000, Dave Airlie wrote:
> On Sat, 2 May 2026 at 18:14, Kenneth Crudup <kenny@panix.com> wrote:
> >
> >
> >
> > On 5/1/26 23:53, Matthew Brost wrote:
> > > TTM pool shrinking frees pages by calling __free_pages() directly,
> > > which bypasses updates to NR_GPU_ACTIVE and leaves GPU MM accounting
> > > out of sync.
> > >
> > > Introduce a helper, __free_pages_gpu_account(), and use it for all page
> > > frees in ttm_pool.c so GPU MM statistics are updated consistently.
> > >
> > > Reported-by: Kenneth Crudup <kenny@panix.com>
> > > Fixes: ae80122f3896 ("drm/ttm: use gpu mm stats to track gpu memory allocations. (v4)")
> > > Cc: Christian Koenig <christian.koenig@amd.com>
> > > Cc: Huang Rui <ray.huang@amd.com>
> > > Cc: Matthew Auld <matthew.auld@intel.com>
> > > Cc: David Airlie <airlied@gmail.com>
> > > Cc: dri-devel@lists.freedesktop.org
> > > Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> > >
> > > ---
> > >
> > > v2:
> 
> Oops, good catch,
> 
> Reviewed-by: Dave Airlie <airlied@redhat.com>

Thanks! Merged to drm-misc-fixes.

Matt

> 
> Dave.

  reply	other threads:[~2026-05-04  4:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-02  6:53 [PATCH v2] drm/ttm: Fix GPU MM stats during pool shrinking Matthew Brost
2026-05-02  6:59 ` ✗ CI.checkpatch: warning for drm/ttm: Fix GPU MM stats during pool shrinking (rev2) Patchwork
2026-05-02  7:00 ` ✓ CI.KUnit: success " Patchwork
2026-05-02  7:54 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-02  8:14 ` [PATCH v2] drm/ttm: Fix GPU MM stats during pool shrinking Kenneth Crudup
2026-05-04  3:56   ` Dave Airlie
2026-05-04  4:09     ` Matthew Brost [this message]
2026-05-02  9:03 ` ✗ Xe.CI.FULL: failure for drm/ttm: Fix GPU MM stats during pool shrinking (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afgb+7p7ecnMGNQL@gsse-cloud1.jf.intel.com \
    --to=matthew.brost@intel.com \
    --cc=airlied@gmail.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=kenny@panix.com \
    --cc=matthew.auld@intel.com \
    --cc=ray.huang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox