From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C77ACD343F for ; Fri, 15 May 2026 19:03:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2485510E15E; Fri, 15 May 2026 19:03:38 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="AKjQajwc"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D74F10E133; Fri, 15 May 2026 19:03:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778871817; x=1810407817; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=GBgknEXJJXOoY5E34cHu5f9HPCa8Hi4z/piAyf/okrQ=; b=AKjQajwc4J4bQayiq8Rtkz94/96OLdVWx+E1heMTFN5JfLoRJ2LYwn6L 1ipx+yM0uaGj17hOj0NdhotSLil0tRB+/jsfAvkyAVyamwLBOBh4Aj9kn 6Cd+lpX0eq7+Ar7Q6BoDb9iIcTHU6jucdbaG8tqx57MaaDHUd8II2vme1 4yCYxh147SLbKCUiG+cA2rMGPwzHTJxrIc2E5yGVu9uCjOysPI89ps7do s5Pg19vBNXKKa5YhheQXFaj5XD6fi9HjTa1LFtHPBMeDLDJdawH2cgew8 dfJv4aurncgahHaazswA0Ocs589BbjPMdxNlWud8rPsjXCaWZHOeaJRuJ g==; X-CSE-ConnectionGUID: sskIpQB4TEejeS1LhCd8vg== X-CSE-MsgGUID: Y9k8qq9LSx6Y0De4TCi4zw== X-IronPort-AV: E=McAfee;i="6800,10657,11787"; a="79862974" X-IronPort-AV: E=Sophos;i="6.23,236,1770624000"; d="scan'208";a="79862974" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2026 12:03:36 -0700 X-CSE-ConnectionGUID: vK8MoxHCSCiFd04mcYatJg== X-CSE-MsgGUID: 5DMUrrZ5TtufYr81ETZ4IQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,236,1770624000"; d="scan'208";a="238654429" Received: from smoticic-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.117]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2026 12:03:34 -0700 Date: Fri, 15 May 2026 22:03:30 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH v4 0/8] drm/i915: add display irq hooks Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, May 13, 2026 at 07:13:23PM +0300, Jani Nikula wrote: > v4 of [1], splitting patches 5-6 into two, resulting in patches 5-8 > here. There's no diff between the end results of v3 and v4, just the > intermediate steps are there. > > BR, > Jani. > > [1] https://lore.kernel.org/r/cover.1778666967.git.jani.nikula@intel.com > > Jani Nikula (8): > drm/i915/irq: deduplicate dg1_de_irq_postinstall() and > gen11_de_irq_postinstall() > drm/i915/irq: constify pipe stats parameters > drm/i915/irq: add display irq funcs, start with > intel_display_irq_reset() > drm/i915/irq: add intel_display_irq_postinstall() to irq funcs > drm/i915/irq: add platform specific display irq ack functions > drm/i915/irq: add platform specific display irq handler functions > drm/i915/irq: add intel_display_irq_ack() to irq funcs > drm/i915/irq: add intel_display_irq_handler() to irq funcs For the series Reviewed-by: Ville Syrjälä > > .../gpu/drm/i915/display/intel_display_core.h | 3 + > .../gpu/drm/i915/display/intel_display_irq.c | 238 +++++++++++++++--- > .../gpu/drm/i915/display/intel_display_irq.h | 37 +-- > drivers/gpu/drm/i915/i915_irq.c | 182 +++++--------- > drivers/gpu/drm/xe/display/xe_display.c | 6 +- > 5 files changed, 277 insertions(+), 189 deletions(-) > > -- > 2.47.3 -- Ville Syrjälä Intel