Re: [PATCH 10/11] drm/i915/dp: Enable AS SDP whenever VRR is possible

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Mon, May 25, 2026 at 10:52:34AM +0530, Ankit Nautiyal wrote:
> Currently AS SDP is only configured when VRR is enabled. With the optimized
> guardband, the guardband must already account for AS SDP wakeup time
> whenever AS SDP can be sent, otherwise turning VRR on after the initial
> modeset could require a larger guardband and trigger a full modeset.
> 
> Switch the check in intel_dp_needs_as_sdp() from crtc_state->vrr.enable
> to intel_vrr_possible(crtc_state), so AS SDP is enabled (and accounted
> for in the guardband) on any configuration where VRR could be turned on,
> not only when it currently is.
> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index a3aa0dadf0e1..c01ce3403ad1 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -3181,7 +3181,7 @@ static bool intel_dp_needs_as_sdp(struct intel_dp *intel_dp,
>  	if (drm_dp_is_branch(intel_dp->dpcd))
>  		return false;
>  
> -	return crtc_state->vrr.enable;
> +	return intel_vrr_possible(crtc_state);

We need AS SDP for the panel replay !async case.

>  }
>  
>  static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp,
> -- 
> 2.45.2

-- 
Ville Syrjälä
Intel