From: Raag Jadav <raag.jadav@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: "Matthew Auld" <matthew.auld@intel.com>,
intel-xe@lists.freedesktop.org,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Matthew Brost" <matthew.brost@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Subject: Re: [PATCH] drm/xe/mmio: Assert MMIO is available
Date: Thu, 28 May 2026 19:43:18 +0200 [thread overview]
Message-ID: <ahh-tqnD6v3JNaTB@black.igk.intel.com> (raw)
In-Reply-To: <d7fd718c-413a-4a7e-83d4-cfb0401194fc@intel.com>
On Thu, May 28, 2026 at 06:16:49PM +0200, Michal Wajdeczko wrote:
...
> and the fact that mmio.regs is still non-NULL and points to the connected HW, is just our luck?
>
> maybe we should kill the HW immediately on pci.remove, if it is still present, and just unwind SW state using devm/drmm actions?
There are a lot of instances where we access MMIO on unwind.
1. irq_uninstall()
2. guc_fini_hw()
3. vf_guc_fini_hw()
4. xe_driver_flr_fini()
... and so on.
I assume the teardown was all part of ->remove() call earlier but now most
of the stuff is hooked to devres ever since we decided to transition to it
sometime last year.
Raag
prev parent reply other threads:[~2026-05-28 17:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 17:54 [PATCH] drm/xe/mmio: Assert MMIO is available Michal Wajdeczko
2026-05-27 19:39 ` ✓ CI.KUnit: success for " Patchwork
2026-05-27 20:31 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-05-28 4:40 ` ✗ Xe.CI.FULL: " Patchwork
2026-05-28 9:13 ` [PATCH] " Matthew Auld
2026-05-28 16:16 ` Michal Wajdeczko
2026-05-28 16:47 ` Matthew Auld
2026-05-28 17:34 ` Michal Wajdeczko
2026-05-28 18:06 ` Raag Jadav
2026-05-29 6:58 ` Matthew Auld
2026-05-28 17:43 ` Raag Jadav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahh-tqnD6v3JNaTB@black.igk.intel.com \
--to=raag.jadav@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=matthew.brost@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox