Re: [PATCH 04/24] drm/xe/display: remove intel_display_flush_cleanup_work() calls on suspend/shutdown

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Fri, May 29, 2026 at 02:03:48PM +0300, Jani Nikula wrote:
> intel_display_driver_suspend() already has drm_atomic_helper_suspend()
> and cleanup workqueue flush. The intel_display_flush_cleanup_work()
> calls on suspend/shutdown should be redundant. Remove.
> 
> Link: https://lore.kernel.org/r/agRp6Was9FCQbKee@intel.com
> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/xe/display/xe_display.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
> index c0d3e7d12823..6e82dc70ca89 100644
> --- a/drivers/gpu/drm/xe/display/xe_display.c
> +++ b/drivers/gpu/drm/xe/display/xe_display.c
> @@ -312,8 +312,6 @@ void xe_display_pm_suspend(struct xe_device *xe)
>  		intel_display_driver_suspend(display);
>  	}
>  
> -	intel_display_flush_cleanup_work(display);
> -
>  	intel_encoder_block_all_hpds(display);
>  
>  	intel_hpd_cancel_work(display);
> @@ -344,7 +342,6 @@ void xe_display_pm_shutdown(struct xe_device *xe)
>  		intel_display_driver_suspend(display);
>  	}
>  
> -	intel_display_flush_cleanup_work(display);

Hmm, apparently the super funky d3cold path still has one call
remaining so can't remove it completely quite yet. Oh well, at
least we're moving to a better direction.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

>  	intel_dp_mst_suspend(display);
>  	intel_encoder_block_all_hpds(display);
>  	intel_hpd_cancel_work(display);
> -- 
> 2.47.3

-- 
Ville Syrjälä
Intel