Re: [PATCH] drm/xe/pcode: Don't ignore drmm_mutex_init failure

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, May 29, 2026 at 09:59:56PM +0200, Michal Wajdeczko wrote:
> The drm_device-managed mutex_init might fail and return an error.
> Add proper error handling. While around, update the function name
> to clearly indicate this is an early software-only initialization.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_pcode.c | 8 +++++---
>  drivers/gpu/drm/xe/xe_pcode.h | 2 +-
>  drivers/gpu/drm/xe/xe_tile.c  | 4 +++-
>  3 files changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pcode.c b/drivers/gpu/drm/xe/xe_pcode.c
> index dc66d0c7ee06..866986694d9c 100644
> --- a/drivers/gpu/drm/xe/xe_pcode.c
> +++ b/drivers/gpu/drm/xe/xe_pcode.c
> @@ -323,15 +323,17 @@ int xe_pcode_ready(struct xe_device *xe, bool locked)
>  }
>  
>  /**
> - * xe_pcode_init: initialize components of PCODE
> + * xe_pcode_init_early() - Initialize components of PCODE
>   * @tile: tile instance
>   *
>   * This function initializes the xe_pcode component.
>   * To be called once only during probe.
> + *
> + * Return: 0 on success or a negative error code on failure.
>   */
> -void xe_pcode_init(struct xe_tile *tile)
> +int xe_pcode_init_early(struct xe_tile *tile)
>  {
> -	drmm_mutex_init(&tile_to_xe(tile)->drm, &tile->pcode.lock);
> +	return drmm_mutex_init(&tile_to_xe(tile)->drm, &tile->pcode.lock);
>  }
>  
>  /**
> diff --git a/drivers/gpu/drm/xe/xe_pcode.h b/drivers/gpu/drm/xe/xe_pcode.h
> index 490e4f269607..18260c29e620 100644
> --- a/drivers/gpu/drm/xe/xe_pcode.h
> +++ b/drivers/gpu/drm/xe/xe_pcode.h
> @@ -12,7 +12,7 @@ struct drm_device;
>  struct xe_device;
>  struct xe_tile;
>  
> -void xe_pcode_init(struct xe_tile *tile);
> +int xe_pcode_init_early(struct xe_tile *tile);
>  int xe_pcode_probe_early(struct xe_device *xe);
>  int xe_pcode_ready(struct xe_device *xe, bool locked);
>  int xe_pcode_init_min_freq_table(struct xe_tile *tile, u32 min_gt_freq,
> diff --git a/drivers/gpu/drm/xe/xe_tile.c b/drivers/gpu/drm/xe/xe_tile.c
> index c465aae7883c..74d925a337b7 100644
> --- a/drivers/gpu/drm/xe/xe_tile.c
> +++ b/drivers/gpu/drm/xe/xe_tile.c
> @@ -157,7 +157,9 @@ int xe_tile_init_early(struct xe_tile *tile, struct xe_device *xe, u8 id)
>  	if (err)
>  		return err;
>  
> -	xe_pcode_init(tile);
> +	err = xe_pcode_init_early(tile);
> +	if (err)
> +		return err;
>  
>  	return 0;
>  }
> -- 
> 2.47.1
>