From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1397DCD6E79 for ; Fri, 5 Jun 2026 12:51:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 99E5411A81F; Fri, 5 Jun 2026 12:51:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="WJs36vPT"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by gabe.freedesktop.org (Postfix) with ESMTPS id 02FAB10E385; Fri, 5 Jun 2026 12:51:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780663899; x=1812199899; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+Z7fkGLCJoGEOW8BWuJGCF5uNojahF7laTSAwAS/N3w=; b=WJs36vPT3LxNz1mo9HvevXWGvSMNL8d5gAMbbREDGxCn8rzKx8IfO7ON 7aOEJJtJYZ6iJyoguIr6CFX1rD6W8pDNQRCoMapSMoc3Zntj+5173XgMU jHyDIyQRHci8y7KUN2VcpkdmeQ0kJT/RXad+dNEVjbxrqtjXLAtA6OPM3 UHzWwh8cjZVUT+bLxXulNZ0JxRBRw7qEiDvBgE6OmvQTcXKlCLbEGbvQD MKDcXqQ3bLP+Z0jFRGJoeo4qrDf7+z8eCDpBze9u2TQdQheCl4mLs2Htk RrCiubw7g6b43HNmgYQENCHL0QEdbKG4Naz9SB49dXK2c6Jx3cXXyU28u w==; X-CSE-ConnectionGUID: KJcEIduQQWSAOF+biwmHKg== X-CSE-MsgGUID: yXFzI7M3RFavKdUnJYoKeQ== X-IronPort-AV: E=McAfee;i="6800,10657,11807"; a="81403401" X-IronPort-AV: E=Sophos;i="6.24,188,1774335600"; d="scan'208";a="81403401" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2026 05:51:38 -0700 X-CSE-ConnectionGUID: 8UYQKWyNSLSmZbmHhYMM2Q== X-CSE-MsgGUID: FID66aKKRv25llgzYSd8vg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,188,1774335600"; d="scan'208";a="282917623" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa001.jf.intel.com with ESMTP; 05 Jun 2026 05:51:28 -0700 Received: by black.igk.intel.com (Postfix, from userid 1008) id C960095; Fri, 05 Jun 2026 14:51:26 +0200 (CEST) Date: Fri, 5 Jun 2026 15:51:22 +0300 From: Heikki Krogerus To: Dmitry Baryshkov Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Greg Kroah-Hartman , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Adrien Grassein , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Tomi Valkeinen , Bjorn Andersson , Konrad Dybcio , Pengyu Luo , Nikita Travkin , Yongxing Mou , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH RESEND v3 1/6] drm/connector: report IRQ_HPD events to drm_connector_oob_hotplug_event() Message-ID: References: <20260513-hpd-irq-events-v3-0-086857017f16@oss.qualcomm.com> <20260513-hpd-irq-events-v3-1-086857017f16@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260513-hpd-irq-events-v3-1-086857017f16@oss.qualcomm.com> X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, May 13, 2026 at 09:23:21PM +0300, Dmitry Baryshkov wrote: > The DisplayPort standard defines a special kind of events called IRQ. > These events are used to notify DP Source about the events on the Sink > side. It is extremely important for DP MST handling, where the MST > events are reported through this IRQ. > > In case of the USB-C DP AltMode there is no actual HPD pulse, but the > events are ported through the bits in the AltMode VDOs. > > Extend the drm_connector_oob_hotplug_event() interface and report IRQ > events to the DisplayPort Sink drivers. > > Signed-off-by: Dmitry Baryshkov The displayport altmode looks okay to me. FWIW: Acked-by: Heikki Krogerus > --- > drivers/gpu/drm/drm_connector.c | 5 ++++- > drivers/usb/typec/altmodes/displayport.c | 15 +++++++++++---- > include/drm/drm_connector.h | 19 ++++++++++++++++++- > 3 files changed, 33 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index 47dc53c4a738..edee9daccd51 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > @@ -3510,6 +3510,8 @@ struct drm_connector *drm_connector_find_by_fwnode(struct fwnode_handle *fwnode) > * drm_connector_oob_hotplug_event - Report out-of-band hotplug event to connector > * @connector_fwnode: fwnode_handle to report the event on > * @status: hot plug detect logical state > + * @extra_status: additional information provided by the sink without changing > + * the HPD state (or in addition to such a change). > * > * On some hardware a hotplug event notification may come from outside the display > * driver / device. An example of this is some USB Type-C setups where the hardware > @@ -3520,7 +3522,8 @@ struct drm_connector *drm_connector_find_by_fwnode(struct fwnode_handle *fwnode) > * a drm_connector reference through calling drm_connector_find_by_fwnode(). > */ > void drm_connector_oob_hotplug_event(struct fwnode_handle *connector_fwnode, > - enum drm_connector_status status) > + enum drm_connector_status status, > + enum drm_connector_status_extra extra_status) > { > struct drm_connector *connector; > > diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c > index 35d9c3086990..7182a8e2e710 100644 > --- a/drivers/usb/typec/altmodes/displayport.c > +++ b/drivers/usb/typec/altmodes/displayport.c > @@ -189,7 +189,9 @@ static int dp_altmode_status_update(struct dp_altmode *dp) > } else { > drm_connector_oob_hotplug_event(dp->connector_fwnode, > hpd ? connector_status_connected : > - connector_status_disconnected); > + connector_status_disconnected, > + (hpd && irq_hpd) ? DRM_CONNECTOR_DP_IRQ_HPD : > + DRM_CONNECTOR_NO_EXTRA_STATUS); > dp->hpd = hpd; > sysfs_notify(&dp->alt->dev.kobj, "displayport", "hpd"); > if (hpd && irq_hpd) { > @@ -212,7 +214,10 @@ static int dp_altmode_configured(struct dp_altmode *dp) > */ > if (dp->pending_hpd) { > drm_connector_oob_hotplug_event(dp->connector_fwnode, > - connector_status_connected); > + connector_status_connected, > + dp->pending_irq_hpd ? > + DRM_CONNECTOR_DP_IRQ_HPD : > + DRM_CONNECTOR_NO_EXTRA_STATUS); > sysfs_notify(&dp->alt->dev.kobj, "displayport", "hpd"); > dp->pending_hpd = false; > if (dp->pending_irq_hpd) { > @@ -397,7 +402,8 @@ static int dp_altmode_vdm(struct typec_altmode *alt, > dp->data.conf = 0; > if (dp->hpd) { > drm_connector_oob_hotplug_event(dp->connector_fwnode, > - connector_status_disconnected); > + connector_status_disconnected, > + DRM_CONNECTOR_NO_EXTRA_STATUS); > dp->hpd = false; > sysfs_notify(&dp->alt->dev.kobj, "displayport", "hpd"); > } > @@ -827,7 +833,8 @@ void dp_altmode_remove(struct typec_altmode *alt) > > if (dp->connector_fwnode) { > drm_connector_oob_hotplug_event(dp->connector_fwnode, > - connector_status_disconnected); > + connector_status_disconnected, > + DRM_CONNECTOR_NO_EXTRA_STATUS); > > fwnode_handle_put(dp->connector_fwnode); > } > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > index f83f28cae207..e05197e970d3 100644 > --- a/include/drm/drm_connector.h > +++ b/include/drm/drm_connector.h > @@ -91,6 +91,22 @@ enum drm_connector_status { > connector_status_unknown = 3, > }; > > +/** > + * enum drm_connector_status_extra - additional events sent by the sink / > + * display together or in replacement of the HPD status changes. > + */ > +enum drm_connector_status_extra { > + /** > + * @DRM_CONNECTOR_NO_EXTRA_STATUS: No additional status reported. > + */ > + DRM_CONNECTOR_NO_EXTRA_STATUS, > + /** > + * @DRM_CONNECTOR_DP_IRQ_HPD: DisplayPort Sink has sent the > + * IRQ_HPD (either by the HPD short pulse or via the AltMode event). > + */ > + DRM_CONNECTOR_DP_IRQ_HPD, > +}; > + > /** > * enum drm_connector_registration_state - userspace registration status for > * a &drm_connector > @@ -2521,7 +2537,8 @@ drm_connector_is_unregistered(struct drm_connector *connector) > } > > void drm_connector_oob_hotplug_event(struct fwnode_handle *connector_fwnode, > - enum drm_connector_status status); > + enum drm_connector_status status, > + enum drm_connector_status_extra extra_status); > const char *drm_get_connector_type_name(unsigned int connector_type); > const char *drm_get_connector_status_name(enum drm_connector_status status); > const char *drm_get_subpixel_order_name(enum subpixel_order order); > > -- > 2.47.3 -- heikki