From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90C0DCD98DA for ; Tue, 16 Jun 2026 09:41:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 429A710E99E; Tue, 16 Jun 2026 09:41:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="eAPLlaYa"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 23B2410E99E; Tue, 16 Jun 2026 09:41:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1781602881; x=1813138881; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6rB2N++QnF7JTGORtVke61SAOuu1kszVTJ+rWarYgM8=; b=eAPLlaYaaU80e0Mt9fmlQwwRZ5Gku+D2oUcf+KJXTAqWfqwH4GLyoQIG 7KhOdiynaaDxuz+8dSqDbb4b7UNtEYZ9ZnxDkNPbjKOpvwtUyUwOBrD6J CDkNr8Q6rgZRa3CXRRvoKqOIItZ3Gd+gvjXETyniJTC6hanIPxxCLfP7C Rsh51Xkutr8CO7jrfO/OiRyteDldW+M06xeUduSPg1nO1YeOYrthJKqe6 WDE2W6KZMm59N3GiytqMlY2TRBTODhAQMAe4o1X93NnAjWXuC26c1uPXX XdjzNa1Ja1iNdyVFYM0BE7Rndkdumanb7pybjUnTPxocES5UFnUexUD77 g==; X-CSE-ConnectionGUID: 3Snm6dK3R/SWzLc+/rNySA== X-CSE-MsgGUID: RxKBzIkxRjujEp4PDXmCdw== X-IronPort-AV: E=McAfee;i="6800,10657,11818"; a="69908024" X-IronPort-AV: E=Sophos;i="6.24,208,1774335600"; d="scan'208";a="69908024" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2026 02:41:20 -0700 X-CSE-ConnectionGUID: AnrLxaW9TzuUK3u43KSRLQ== X-CSE-MsgGUID: M1WMwv/PSYC4Tunnc2YqKw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,208,1774335600"; d="scan'208";a="251644879" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa003.jf.intel.com with ESMTP; 16 Jun 2026 02:41:10 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id AD51695; Tue, 16 Jun 2026 11:41:08 +0200 (CEST) Date: Tue, 16 Jun 2026 11:41:08 +0200 From: Andy Shevchenko To: Johan Hovold Cc: Bartosz Golaszewski , Lee Jones , Mark Brown , Thierry Reding , Sebastian Hesselbarth , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Srinivas Kandagatla , Greg Kroah-Hartman , Vinod Koul , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Saravana Kannan , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Andi Shyti , Joerg Roedel , Will Deacon , Robin Murphy , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Ulf Hansson , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Matthew Brost , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Rodrigo Vivi , David Airlie , Simona Vetter , Peter Chen , Paul Cercueil , Bin Liu , Philipp Zabel , Maximilian Luz , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Krzysztof Kozlowski , Benjamin Herrenschmidt , brgl@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, driver-core@lists.linux.dev, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-i2c@vger.kernel.org, iommu@lists.linux.dev, linux-pm@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-mips@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 08/23] driver core: platform: provide platform_device_set_of_node_from_dev() Message-ID: References: <20260521-pdev-fwnode-ref-v1-0-88c324a1b8d2@oss.qualcomm.com> <20260521-pdev-fwnode-ref-v1-8-88c324a1b8d2@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, Jun 08, 2026 at 09:03:02AM +0200, Johan Hovold wrote: > On Fri, Jun 05, 2026 at 05:53:04PM +0300, Andy Shevchenko wrote: > > On Fri, Jun 05, 2026 at 02:16:17PM +0200, Johan Hovold wrote: > > > On Wed, Jun 03, 2026 at 12:44:55AM +0300, Andy Shevchenko wrote: > > > > On Thu, May 21, 2026 at 10:36:31AM +0200, Bartosz Golaszewski wrote: > > > > > Provide a platform-specific variant of device_set_of_node_from_dev(). In > > > > > addition to bumping the reference count of the OF node being assigned, > > > > > it also assigns the fwnode of the platform device. > > > > > > > > Can we rather investigate the way how to make that of node reuse thingy > > > > (which is used solely by pin control) differently and then drop this confusing > > > > device_set_of_node_from_dev() call altogether? > > > > > > No, that call is needed. See commit 4e75e1d7dac9 ("driver core: add > > > helper to reuse a device-tree node") for details. > > > > Bart fixes the problem with the platform driver. At the result this will be > > the only device_set_node() + 'reused = true'. As for 'reused' flag, the need > > is only for pinmux/pin control stuff. > > And any other resource which may (eventually) be claimed by driver core > or bus code. > > > The question here is if there is a better > > way to make that 'reused' be done automatically without need of setting some > > flag explicitly. > > That's not really relevant to the series at hand. It's not, but it's relevant in a long-term for understanding how we can get this done in a better way. > If this is something we want to merge then you need to continue setting > the flag in order not to cause regressions. Yes, that's how it's now. -- With Best Regards, Andy Shevchenko