From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03EF4CDB47C for ; Wed, 24 Jun 2026 10:31:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9B23F10EE84; Wed, 24 Jun 2026 10:31:51 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="c/pdAAqg"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id EDFE710EE7D; Wed, 24 Jun 2026 10:31:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782297111; x=1813833111; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=DtJ/CNN9GumTvr2hAj6sRgQ9MHu53c3lB1R067sVku8=; b=c/pdAAqgNnSqHxYEADCgqwqiXxMMAlZfV6+TclF6uviA63in/Q+eu0o2 8G2YYXMry8WTCu7vDb3WTrSYhVQhzpraWHvP1KdbwmhthtJOgPEp3X9RK o4W9ZIUrBo9W4Ey7nGNs4rBublR/m2VFjUcosa0llTsW7bxXYNHXmWzQg F+KTDZ4QM8JqeCPG7NsKKCdj2MOfA1TFpP7KzV11iSooieONVYpKxWAI5 CMrbF7XAgAVG3EQlVVe2qklpXJZejAZYuGuKQwdQPsFNP/5kUCduZhFV3 qXVEgq7OFZCZIcFUwuX3ELL8yoIQq9/RpRsmXnSSA6SV6G6cFPGC62RMw Q==; X-CSE-ConnectionGUID: AUr9s5GzRc+xOagyIMuimQ== X-CSE-MsgGUID: ViBzy96DQJ6TpwulJLLGbQ== X-IronPort-AV: E=McAfee;i="6800,10657,11826"; a="86898254" X-IronPort-AV: E=Sophos;i="6.24,222,1774335600"; d="scan'208";a="86898254" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2026 03:31:50 -0700 X-CSE-ConnectionGUID: gZSgSSrXSQGPs8UD06tZCg== X-CSE-MsgGUID: lU/PpAQQT8efGMJ9IEQrjA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,222,1774335600"; d="scan'208";a="253690412" Received: from kniemiec-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.244]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2026 03:31:48 -0700 Date: Wed, 24 Jun 2026 13:31:43 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Joonas Lahtinen Cc: =?iso-8859-1?Q?Gabr=EDel_Arth=FAr_P=E9tursson?= , "intel-gfx@lists.freedesktop.org" , "intel-xe@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "jani.nikula@linux.intel.com" , "rodrigo.vivi@intel.com" , "tursulin@ursulin.net" Subject: Re: [PATCH] drm/i915: Calculate CDCLK on modeset after sanitizing pre-os programming Message-ID: References: <178228365985.16303.14222363163462260344@jlahtine-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <178228365985.16303.14222363163462260344@jlahtine-mobl> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, Jun 24, 2026 at 09:47:39AM +0300, Joonas Lahtinen wrote: > Quoting Ville Syrjälä (2026-06-23 17:24:43) > > This smells like the same thing I already fixed with > > commit 3f9de66f8acb ("drm/i915/cdclk: Fix up CDCLK_FREQ_DECIMAL > > without a full PLL re-enable") > > > > Sadly it looks like I forgot to cc:stable it :/ > > > > Jani, can you pick that up for -fixes and slap a cc:stable on it? > > I'll include it in drm-intel-next-fixes, do we have a > Fixes: tag to add? It's been basically broken forever so the correct fixes tags probably aren't super useful. However the nastier user visible regression happened in commit ba91b9eecb47 ("drm/i915/cdclk: Decouple cdclk from state->modeset") which therefore might make sense as a fixes tag. But if we put that in then I'm worried that it won't get backported to older kernels. I guess we could throw that in there along with the ancient commits that actually introduced the problem. So something along the lines of: Fixes: ba91b9eecb47 ("drm/i915/cdclk: Decouple cdclk from state->modeset") Fixes: d66a21947e21 ("drm/i915/bxt: Sanitize CDCLK to fix breakage during S4 resume") Fixes: c73666f394fc ("drm/i915/skl: If needed sanitize bios programmed cdclk") -- Ville Syrjälä Intel