From: Raag Jadav <raag.jadav@intel.com>
To: "Tauro, Riana" <riana.tauro@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
kuba@kernel.org, aravind.iddamsetty@linux.intel.com,
intel-xe@lists.freedesktop.org, anshuman.gupta@intel.com,
joonas.lahtinen@linux.intel.com, simona.vetter@ffwll.ch,
airlied@gmail.com, pratik.bari@intel.com,
joshua.santosh.ranjan@intel.com, ashwin.kumar.kulkarni@intel.com,
shubham.kumar@intel.com, ravi.kishore.koppuravuri@intel.com,
maarten.lankhorst@linux.intel.com, mallesh.koujalagi@intel.com,
soham.purkait@intel.com,
Zack McKevitt <zachary.mckevitt@oss.qualcomm.com>,
Lijo Lazar <lijo.lazar@amd.com>,
Hawking Zhang <Hawking.Zhang@amd.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
dri-devel@lists.freedesktop.org, netdev@vger.kernel.org
Subject: Re: [PATCH v4 1/3] drm/drm_ras: Add drm_ras netlink error event
Date: Thu, 9 Jul 2026 11:22:26 +0200 [thread overview]
Message-ID: <ak9oUmZ8sS3aF6jB@black.igk.intel.com> (raw)
In-Reply-To: <d96a4c3f-e0e7-42d7-bb8a-994b2f408dea@intel.com>
On Thu, Jul 09, 2026 at 10:45:27AM +0530, Tauro, Riana wrote:
> On 09-07-2026 01:51, Rodrigo Vivi wrote:
> > On Tue, Jul 07, 2026 at 12:02:11PM +0530, Tauro, Riana wrote:
> > > Hi Rodrigo/Jakub/Aravind
> > >
> > > Please let me know if you have any feedback for this patch or can you please
> > > ack this if it looks good to you.
> > I looks good to me, but could you please double check the sashiko's comments?
>
> Sashiko has a comment regarding namespaces
>
> [Severity: Medium]Since the generic netlink family explicitly supports
> multiple networknamespaces by setting .netnsok = true,
> will hardcoding init_net hereprevent listeners in non-init namespaces from
> receiving error events
>
> .netnsok = true is auto generated not explicitly added in code.
Because that's what ynl_gen_c.py does without it being parsed from
anywhere.
> But from what i see, drm device is present in the host and not replicated
> across namespaces
> and most of the non-network implementations use inet. (ex: Binder)
> If this really needs a fix, we can drop the has_listeners suggested by raag
> in previous patch.
> I don't think in an error path, allocating a new buffer would be a big
> overhead if listeners are not present.
I don't know enough about namespaces to comment on this. I'll rely on
Jakub's disposition if netnsok is relevant here, or needed at all for
our usecase.
Raag
next prev parent reply other threads:[~2026-07-09 9:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 9:44 [PATCH v4 0/3] Add drm_ras netlink error event support Riana Tauro
2026-07-01 9:44 ` [PATCH v4 1/3] drm/drm_ras: Add drm_ras netlink error event Riana Tauro
2026-07-07 6:32 ` Tauro, Riana
2026-07-08 20:21 ` Rodrigo Vivi
2026-07-09 5:15 ` Tauro, Riana
2026-07-09 9:22 ` Raag Jadav [this message]
2026-07-01 9:44 ` [PATCH v4 2/3] drm/xe/xe_drm_ras: Add error-event support for PVC Riana Tauro
2026-07-01 9:44 ` [PATCH v4 3/3] drm/xe/xe_ras: Add error-event support for CRI Riana Tauro
2026-07-09 10:04 ` Raag Jadav
2026-07-01 10:52 ` ✓ CI.KUnit: success for Add drm_ras netlink error event support (rev4) Patchwork
2026-07-01 11:32 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-02 3:52 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak9oUmZ8sS3aF6jB@black.igk.intel.com \
--to=raag.jadav@intel.com \
--cc=Hawking.Zhang@amd.com \
--cc=airlied@gmail.com \
--cc=anshuman.gupta@intel.com \
--cc=aravind.iddamsetty@linux.intel.com \
--cc=ashwin.kumar.kulkarni@intel.com \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=joshua.santosh.ranjan@intel.com \
--cc=kuba@kernel.org \
--cc=lijo.lazar@amd.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mallesh.koujalagi@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pratik.bari@intel.com \
--cc=ravi.kishore.koppuravuri@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=shubham.kumar@intel.com \
--cc=simona.vetter@ffwll.ch \
--cc=soham.purkait@intel.com \
--cc=zachary.mckevitt@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox