Re: [PATCH v1] drm/xe/i2c: Drop manual VF check

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

On Tue, Jun 30, 2026 at 02:48:00PM +0530, Raag Jadav wrote:
> Clear has_i2c flag inside vf_update_device_info() instead of manually
> checking for VF instance.
> 
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>

FWIW:

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/gpu/drm/xe/xe_device.c | 1 +
>  drivers/gpu/drm/xe/xe_i2c.c    | 3 ---
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index e8b6afb29ab6..cfd4983be411 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -745,6 +745,7 @@ static void vf_update_device_info(struct xe_device *xe)
>  	xe->info.probe_display = 0;
>  	xe->info.has_heci_cscfi = 0;
>  	xe->info.has_heci_gscfi = 0;
> +	xe->info.has_i2c = 0;
>  	xe->info.has_late_bind = 0;
>  	xe->info.skip_guc_pc = 1;
>  	xe->info.skip_pcode = 1;
> diff --git a/drivers/gpu/drm/xe/xe_i2c.c b/drivers/gpu/drm/xe/xe_i2c.c
> index 706783863d07..bd956776b10b 100644
> --- a/drivers/gpu/drm/xe/xe_i2c.c
> +++ b/drivers/gpu/drm/xe/xe_i2c.c
> @@ -334,9 +334,6 @@ int xe_i2c_probe(struct xe_device *xe)
>  	if (!xe->info.has_i2c)
>  		return 0;
>  
> -	if (IS_SRIOV_VF(xe))
> -		return 0;
> -
>  	xe_i2c_read_endpoint(xe_root_tile_mmio(xe), &ep);
>  	if (ep.cookie != XE_I2C_EP_COOKIE_DEVICE)
>  		return 0;
> -- 
> 2.43.0

-- 
heikki