From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "LIOU, Mei Fan" <mei.fan.liou@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Arun R Murthy <arun.r.murthy@intel.com>
Subject: Re: [PATCH] drm/i915: skip eDP hw probe when connector forced off via cmdline
Date: Fri, 10 Jul 2026 16:56:02 +0300 [thread overview]
Message-ID: <alD58t0ihoGmzbj7@intel.com> (raw)
In-Reply-To: <20260707085704.14519-1-mei.fan.liou@intel.com>
On Tue, Jul 07, 2026 at 04:57:04PM +0800, LIOU, Mei Fan wrote:
> When eDP connector is forced off (video=eDP-1:d),
> intel_edp_init_connector() ignores the force flag and still probes
> the AUX channel for DPCD and EDID.
>
> video=eDP-1:d sets connector->force = DRM_FORCE_OFF via
> drm_connector_get_cmdline_mode() inside drm_connector_init_with_ddc(),
> which logs 'forcing eDP-1 connector off'. However,
> intel_edp_init_connector() is called immediately after and ignores
> the force flag, so AUX/PPS probing still occurs.
>
> Fix this by checking connector->base.force == DRM_FORCE_OFF in
> intel_edp_init_connector() after the intel_dp_is_edp() check, before
> any AUX/DPCD probing is attempted. When the connector is forced off,
> log an informational message and goto out_vdd_off to properly clean
> up PPS state and skip all remaining hardware probing.
>
> Suggested-by: Arun R Murthy <arun.r.murthy@intel.com>
> Signed-off-by: LIOU, Mei Fan <mei.fan.liou@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 3569e61e7fee..fa61b299f83e 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -7057,6 +7057,17 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp,
>
> intel_alpm_init(intel_dp);
>
> + /*
> + * If the connector has been forced off via the kernel cmdline
> + * (e.g. video=eDP-1:d), skip DPCD/AUX probing.
> + */
> + if (connector->base.force == DRM_FORCE_OFF) {
> + drm_info(display->drm,
> + "[ENCODER:%d:%s] eDP disabled via cmdline, skipping eDP init\n",
> + encoder->base.base.id, encoder->base.name);
> + goto out_vdd_off;
> + }
This doesn't looks sane if the eDP panel is actually there. We need to
turn it off gracefully.
> +
> /* Cache DPCD and EDID for edp. */
> has_dpcd = intel_edp_init_dpcd(intel_dp, connector);
>
> --
> 2.52.0
--
Ville Syrjälä
Intel
prev parent reply other threads:[~2026-07-10 13:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 8:57 [PATCH] drm/i915: skip eDP hw probe when connector forced off via cmdline LIOU, Mei Fan
2026-07-07 9:04 ` ✓ CI.KUnit: success for " Patchwork
2026-07-07 9:43 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-07 11:59 ` ✓ Xe.CI.FULL: " Patchwork
2026-07-10 13:56 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alD58t0ihoGmzbj7@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@gmail.com \
--cc=arun.r.murthy@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mei.fan.liou@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox