Re: [PATCH] drm/xe/pf: Disable display in admin only PF mode

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, Jun 15, 2026 at 10:21:47AM +0200, Piotr Piórkowski wrote:
> Piotr Piórkowski <piotr.piorkowski@intel.com> wrote on czw [2026-cze-11 16:21:27 +0200]:
> > Satyanarayana K V P <satyanarayana.k.v.p@intel.com> wrote on czw [2026-cze-11 12:42:06 +0000]:
> > > Admin-only PF mode does not expose media or 3D execution capabilities
> > > to userspace, so display pipelines cannot receive rendered content.
> > > 
> > > Fixes: d88c4bac8c2a ("drm/xe/pf: Restrict device query responses in admin-only PF mode")
> > > 
> > > Signed-off-by: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
> > > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > > Cc: Piotr Piórkowski <piotr.piorkowski@intel.com>
> > > Cc: Michał Winiarski <michal.winiarski@intel.com>
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > ---
> > >  drivers/gpu/drm/xe/xe_device.c | 2 --
> > >  drivers/gpu/drm/xe/xe_pci.c    | 4 +++-
> > >  2 files changed, 3 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> > > index 51e3a2dd7b22..9c02e0e314c7 100644
> > > --- a/drivers/gpu/drm/xe/xe_device.c
> > > +++ b/drivers/gpu/drm/xe/xe_device.c
> > > @@ -426,7 +426,6 @@ static const struct drm_ioctl_desc xe_ioctls_admin_only[] = {
> > >  
> > >  static const struct drm_driver admin_only_driver = {
> > >  	.driver_features =
> > > -	    XE_DISPLAY_DRIVER_FEATURES |
> > >  	    DRIVER_GEM | DRIVER_RENDER,
> > >  	.open = xe_file_open,
> > >  	.postclose = xe_file_close,
> > > @@ -438,7 +437,6 @@ static const struct drm_driver admin_only_driver = {
> > >  	.major = DRIVER_MAJOR,
> > >  	.minor = DRIVER_MINOR,
> > >  	.patchlevel = DRIVER_PATCHLEVEL,
> > > -	XE_DISPLAY_DRIVER_OPS,
> > >  };
> > >  
> > >  /**
> > > diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> > > index 78fc2e4dcfc6..6fd882443fa5 100644
> > > --- a/drivers/gpu/drm/xe/xe_pci.c
> > > +++ b/drivers/gpu/drm/xe/xe_pci.c
> > > @@ -789,7 +789,9 @@ static int xe_info_init_early(struct xe_device *xe,
> > >  
> > >  	xe->info.probe_display = IS_ENABLED(CONFIG_DRM_XE_DISPLAY) &&
> > >  				 xe_modparam.probe_display &&
> > > -				 desc->has_display;
> > > +				 desc->has_display &&
> > > +				 !xe_device_is_admin_only(xe);
> > > +
> > >  	xe->info.force_execlist = xe_modparam.force_execlist;
> > >  
> > >  	xe_assert(xe, desc->max_gt_per_tile > 0);
> > > -- 
> > > 2.43.0
> > > 
> > 
> > LGTM: Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>
> 
> To make patchwork happy:
> Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>

Sorry for the delay here.
I was going to merge it right now, but I got a conflict.
Could you please rebase and resend it?

Thanks,
Rodrigo.

> 
> > 
> > 
> > -- 
> 
> --