Re: [PATCH, v2] drm/xe: Reject PXP usage on multi-queue exec queues

[Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>]

On Tue, Jul 14, 2026 at 03:44:49AM +0800, Jagmeet Randhawa wrote:

Use 'drm/xe/multi_queue:' in the commit title as it is multi-queue related.

>HWDRM is currently the only supported PXP type, and it is display
>related, so it cannot be combined with multi-queue exec queue groups.
>Reject exec queue creation that requests both multi-queue and PXP,
>returning -EINVAL.
>
>The secondary queue path already rejects any PXP property, so this
>adds the missing check for the multi-queue primary,
>which would otherwise allow the combination.
>
>Validated with igt@xe_exec_multi_queue@sanity, which exercises both
>the PXP-unsupported (-ENODEV) and PXP-supported (-EINVAL) paths.
>

Requires 'v2: <changes done in v2>' required.
It is fine this time thoguh.

Reviewed-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>

>Signed-off-by: Jagmeet Randhawa <jagmeet.randhawa@intel.com>
>---
> drivers/gpu/drm/xe/xe_exec_queue.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
>diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c b/drivers/gpu/drm/xe/xe_exec_queue.c
>index 1b5ca3ce578a..ea8546b67e6e 100644
>--- a/drivers/gpu/drm/xe/xe_exec_queue.c
>+++ b/drivers/gpu/drm/xe/xe_exec_queue.c
>@@ -1056,6 +1056,7 @@ int xe_exec_queue_set_property_ioctl(struct drm_device *dev, void *data,
>
> static int exec_queue_user_ext_check(struct xe_exec_queue *q, u64 properties)
> {
>+	struct xe_device *xe = gt_to_xe(q->gt);
> 	u64 secondary_queue_valid_props = BIT_ULL(DRM_XE_EXEC_QUEUE_SET_PROPERTY_MULTI_GROUP) |
> 				  BIT_ULL(DRM_XE_EXEC_QUEUE_SET_PROPERTY_MULTI_QUEUE_PRIORITY);
>
>@@ -1067,6 +1068,16 @@ static int exec_queue_user_ext_check(struct xe_exec_queue *q, u64 properties)
> 	    properties & ~secondary_queue_valid_props)
> 		return -EINVAL;
>
>+	/*
>+	 * HWDRM is the only supported PXP type today. It is display related and
>+	 * hence can't work with multi-queue. Reject the combination. The secondary
>+	 * queue path above already rejects any PXP property, so this also covers
>+	 * the multi-queue primary which would otherwise allow it.
>+	 */
>+	if (XE_IOCTL_DBG(xe, (properties & BIT_ULL(DRM_XE_EXEC_QUEUE_SET_PROPERTY_MULTI_GROUP)) &&
>+				(properties & BIT_ULL(DRM_XE_EXEC_QUEUE_SET_PROPERTY_PXP_TYPE))))
>+		return -EINVAL;
>+
> 	return 0;
> }
>
>-- 
>2.53.0
>