Re: [PATCH v1] drm/xe/i2c: Allow per domain unique id

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

On Tue, Jul 21, 2026 at 05:04:38PM +0530, Raag Jadav wrote:
> PCI bus, device and function can be same for devices existing across
> different domains. Allow per domain unique identifier while registering
> platform device to prevent name conflict.
> 
> Fixes: f0e53aadd702 ("drm/xe: Support for I2C attached MCUs")
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>

FWIW:

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/gpu/drm/xe/xe_i2c.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_i2c.c b/drivers/gpu/drm/xe/xe_i2c.c
> index bd956776b10b..a26c38bb17a1 100644
> --- a/drivers/gpu/drm/xe/xe_i2c.c
> +++ b/drivers/gpu/drm/xe/xe_i2c.c
> @@ -95,18 +95,21 @@ static int xe_i2c_register_adapter(struct xe_i2c *i2c)
>  	struct platform_device *pdev;
>  	struct fwnode_handle *fwnode;
>  	int ret;
> +	u32 id;
>  
>  	fwnode = fwnode_create_software_node(xe_i2c_adapter_properties, NULL);
>  	if (IS_ERR(fwnode))
>  		return PTR_ERR(fwnode);
>  
> +	id = (pci_domain_nr(pci->bus) << 16) | pci_dev_id(pci);
> +
>  	/*
>  	 * Not using platform_device_register_full() here because we don't have
>  	 * a handle to the platform_device before it returns. xe_i2c_notifier()
>  	 * uses that handle, but it may be called before
>  	 * platform_device_register_full() is done.
>  	 */
> -	pdev = platform_device_alloc(adapter_name, pci_dev_id(pci));
> +	pdev = platform_device_alloc(adapter_name, id);
>  	if (!pdev) {
>  		ret = -ENOMEM;
>  		goto err_fwnode_remove;
> -- 
> 2.43.0

-- 
heikki