From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Julia Filipchuk <julia.filipchuk@intel.com>
Cc: Zhanjun Dong <zhanjun.dong@intel.com>,
<intel-xe@lists.freedesktop.org>, <matthew.brost@intel.com>
Subject: Re: [PATCH v6 2/2] drm/xe/guc: Compress GuC log and CTB dump with zstd
Date: Wed, 22 Jul 2026 16:12:53 -0400 [thread overview]
Message-ID: <amEkRTttC5-ldITs@intel.com> (raw)
In-Reply-To: <7367ab63-127e-4926-933f-d529b72d5faf@intel.com>
On Wed, Jul 22, 2026 at 12:11:27PM -0700, Julia Filipchuk wrote:
>
> Looks good to me.
>
> Reviewed-by: Julia Filipchuk <julia.filipchuk@intel.com>
Please do not merge this commit.
It fails to explain the most important thing in the commit message: the **why**!
It has the change to bring regression to existing tools as well.
Thanks,
Rodrigo.
next prev parent reply other threads:[~2026-07-22 20:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 18:06 [PATCH v6 0/2] drm/xe/guc: Compress GuC log and CTB dump with zstd Zhanjun Dong
2026-07-22 18:06 ` [PATCH v6 1/2] drm/xe: Remove extra newlines from LRC snapshot dump Zhanjun Dong
2026-07-22 18:06 ` [PATCH v6 2/2] drm/xe/guc: Compress GuC log and CTB dump with zstd Zhanjun Dong
2026-07-22 19:11 ` Julia Filipchuk
2026-07-22 20:12 ` Rodrigo Vivi [this message]
2026-07-22 20:37 ` ✗ CI.checkpatch: warning for drm/xe/guc: Compress GuC log and CTB dump with zstd (rev2) Patchwork
2026-07-22 20:39 ` ✓ CI.KUnit: success " Patchwork
2026-07-22 21:28 ` ✓ Xe.CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amEkRTttC5-ldITs@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=julia.filipchuk@intel.com \
--cc=matthew.brost@intel.com \
--cc=zhanjun.dong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox