Re: [PATCH v4 31/32] drm/xe/gt: Report 'Queue full' pagefault error using SIGID

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, Aug 12, 2026 at 09:14:47PM +0200, Michal Wajdeczko wrote:
> Report 'Queue full' error using xe_log_err() helper.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
> Cc: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_pagefault.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c
> index eb600c466187..f0e173a251e4 100644
> --- a/drivers/gpu/drm/xe/xe_pagefault.c
> +++ b/drivers/gpu/drm/xe/xe_pagefault.c
> @@ -328,8 +328,10 @@ xe_pagefault_queue_add(struct xe_pagefault_queue *pf_queue,
>  
>  	do {
>  		/* Not possible, warn on and drop page fault */
> -		if (WARN_ON(xe_pagefault_queue_full(pf_queue)))
> +		if (WARN_ON_ONCE(xe_pagefault_queue_full(pf_queue))) {

Please mention in the commit message that we are replacing the WARN_ON
per WARN_ON_ONCE to avoid the extra noise and also because once is
enough anyway.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> +			xe_log_err(xe, PAGEFAULT, -ENOSPC, "Queue full!\n");
>  			return NULL;
> +		}
>  
>  		lpf = (pf_queue->data + pf_queue->head);
>  		pf_queue->head = (pf_queue->head + xe_pagefault_entry_size()) %
> -- 
> 2.47.1
>