Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Dan Carpenter <error27@gmail.com>
Cc: "Matthew Brost" <matthew.brost@intel.com>,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Matt Roper" <matthew.d.roper@intel.com>,
	"Matthew Auld" <matthew.auld@intel.com>,
	"Xin Wang" <x.wang@intel.com>,
	"Balasubramani Vivekanandan"
	<balasubramani.vivekanandan@intel.com>,
	intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm/xe: tests: fix error message in xe_migrate_sanity_test()
Date: Thu, 13 Aug 2026 09:39:03 -0400	[thread overview]
Message-ID: <an3I99w2KFz6dPul@intel.com> (raw)
In-Reply-To: <an1tu0z3T-qX1ogn@stanley.mountain>

On Thu, Aug 13, 2026 at 10:09:47AM +0300, Dan Carpenter wrote:
> This is supposed to print the error code but there is a copy and
> paste bug so it prints "bo" instead of "err".
> 
> Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
> Signed-off-by: Dan Carpenter <error27@gmail.com>

pushed, thanks for the fix

> ---
>  drivers/gpu/drm/xe/tests/xe_migrate.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/tests/xe_migrate.c b/drivers/gpu/drm/xe/tests/xe_migrate.c
> index 3c1be809be82..f10d9513747b 100644
> --- a/drivers/gpu/drm/xe/tests/xe_migrate.c
> +++ b/drivers/gpu/drm/xe/tests/xe_migrate.c
> @@ -198,8 +198,7 @@ static void xe_migrate_sanity_test(struct xe_migrate *m, struct kunit *test,
>  
>  	err = xe_bo_vmap(bo);
>  	if (err) {
> -		KUNIT_FAIL(test, "Failed to vmap our pagetables: %li\n",
> -			   PTR_ERR(bo));
> +		KUNIT_FAIL(test, "Failed to vmap our pagetables: %d\n", err);
>  		return;
>  	}
>  
> -- 
> 2.53.0
> 

      parent reply	other threads:[~2026-08-13 13:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13  7:09 [PATCH] drm/xe: tests: fix error message in xe_migrate_sanity_test() Dan Carpenter
2026-08-13  7:10 ` ✗ LGCI.VerificationFailed: failure for " Patchwork
2026-08-13 13:39 ` Rodrigo Vivi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=an3I99w2KFz6dPul@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=airlied@gmail.com \
    --cc=balasubramani.vivekanandan@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=error27@gmail.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.auld@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=matthew.d.roper@intel.com \
    --cc=simona@ffwll.ch \
    --cc=thomas.hellstrom@linux.intel.com \
    --cc=x.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox