intel-xe.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Michał Winiarski" <michal.winiarski@intel.com>
To: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Cc: intel-xe@lists.freedesktop.org,
	"Michał Wajdeczko" <michal.wajdeczko@intel.com>
Subject: Re: [PATCH] drm/xe/pf: Keep VF LMEM BAR size low if no VFs enabled
Date: Wed, 9 Sep 2026 13:03:38 +0200	[thread overview]
Message-ID: <aqE81KpJiLE0R8KE@nostramo> (raw)
In-Reply-To: <20260902124751.512730-1-marcin.bernatowicz@linux.intel.com>

On Wed, Sep 02, 2026 at 02:47:51PM +0200, Marcin Bernatowicz wrote:
> When VFs are enabled on dGFX the driver resizes the PF VF_LMEM_BAR to
> fit the requested layout. After VFs are disabled the PF VF BAR
> size is left as-is. On platforms with tight MMIO apertures a
> subsequent unplug/rescan followed by another enable may fail with:
> 
>   "VF BAR …: can't assign; no space"
> 
> because the PCI core reserves address space based on the (now large) VF
> template, often multiplied by totalvfs.
> 
> Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/5937
> Fixes: 94eae6ee4c2d ("drm/xe/pf: Set VF LMEM BAR size")
> Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
> Cc: Michał Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Michał Winiarski <michal.winiarski@intel.com>

Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>

Thanks,
-Michał

> ---
> v3:
>  - rebased to resolve conflicts, no other functional changes were done
> v2:
>  - Rename helper to restore_vf_vram_bar_size() (Michal)
>  - Use xe->sriov.pf.device_total_vfs instead of pci_sriov_get_totalvfs(),
>    which may be capped (Michal)
>  - Switch logging to %pe (Michal)
>  - Call restore unconditionally on enable-fail path (Michal)
>    (drop vf_vram_bar_resized flag)
> ---
>  drivers/gpu/drm/xe/xe_pci_sriov.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)

  parent reply	other threads:[~2026-09-09 11:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 12:47 [PATCH] drm/xe/pf: Keep VF LMEM BAR size low if no VFs enabled Marcin Bernatowicz
2026-09-02 14:10 ` ✓ CI.KUnit: success for drm/xe/pf: Keep VF LMEM BAR size low if no VFs enabled (rev3) Patchwork
2026-09-02 15:07 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-09-03  2:32 ` ✗ Xe.CI.FULL: " Patchwork
2026-09-09 11:03 ` Michał Winiarski [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-09-22  8:57 [PATCH] drm/xe/pf: Keep VF LMEM BAR size low if no VFs enabled Marcin Bernatowicz
2025-09-18 16:43 Marcin Bernatowicz
2025-09-18 18:24 ` Michal Wajdeczko
2025-09-19 16:22   ` Bernatowicz, Marcin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqE81KpJiLE0R8KE@nostramo \
    --to=michal.winiarski@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=marcin.bernatowicz@linux.intel.com \
    --cc=michal.wajdeczko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).