Re: [PATCH v2 12/13] drm/i915/dsb: Add tracepoints for DSB commit

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Sep 09, 2026 at 04:34:49PM +0000, sashiko-bot@kernel.org wrote:
> > diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
> > index 8e01e1eed291e..299d778520a22 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> [ ... ]
> > @@ -1124,6 +1127,8 @@ void intel_dsb_irq_handler(struct intel_display *display,
> >  		spin_lock(&display->drm->event_lock);
> >  
> >  		if (crtc->dsb_event) {
> > +			trace_intel_dsb_done(crtc, dsb_id);
> > +
> 
> [Severity: Medium]
> Will this lead to unbalanced commit/done trace events for background updates?
> 
> The trace_intel_dsb_done() tracepoint is conditionally called only when a
> userspace vblank event is present. If a commit completes in hardware
> without an associated vblank event, the irq handler will skip emitting the
> completion tracepoint.

There is never a commit without an associated vblank event. See
drm_atomic_helper_setup_commit().

-- 
Ville Syrjälä
Intel