Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Cc: <dri-devel@lists.freedesktop.org>, <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v2 0/6] drm: consolidate self-imported PRIME dma-buf detection
Date: Mon, 12 Oct 2026 18:38:34 -0700	[thread overview]
Message-ID: <as2Lmp0A5EwH2OC8@gsse-cloud1.jf.intel.com> (raw)
In-Reply-To: <20261013010614.1516799-8-niranjana.vishwanathapura@intel.com>

On Mon, Oct 12, 2026 at 06:06:12PM -0700, Niranjana Vishwanathapura wrote:
> Detecting that a PRIME dma-buf being imported was exported by the same
> DRM device is a pattern currently open-coded in many drivers (compare
> dma_buf->ops against the driver's own ops, check obj->dev == dev, then
> return the GEM object with an extra reference). This series adds generic
> helpers for it and converts several drivers to use them.
> 
> Patch 1 adds drm_gem_prime_self_import(dev, dma_buf, ops): for a dma-buf
> self-exported via the given ops, it returns the backing GEM object with
> a reference, letting a driver short-circuit the generic PRIME import and
> skip the extra dma-buf file reference. Patch 2 converts Xe to it.
> 
> Patch 3 adds drm_gem_prime_dma_buf_to_gem(), a thin wrapper that uses the
> core PRIME ops, and replaces the drm_gem_is_prime_exported_dma_buf() bool
> predicate with it so the shmem importer resolves the object directly
> (the sole caller already wanted the referenced object).
> 
> Patches 4-6 convert panthor, panfrost and amdgpu to
> drm_gem_prime_self_import(), removing the duplicated open-coded checks.
> 
> No intended functional change.
> 
> Assisted-by: GitHub-Copilot:claude-opus-4.8
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> 
> Farah Kassabri (2):
>   drm/gem: add helper to detect self-imported PRIME dma-bufs
>   drm/xe/dma-buf: Use drm helper to detect dma-buf self-import
> 
> Niranjana Vishwanathapura (4):
>   drm/gem: add drm_gem_prime_dma_buf_to_gem() self-import helper

For the other driver patches:

Acked-by: Matthew Brost <matthew.brost@intel.com>

I'll leave the RB's to individual maintainers.

>   drm/panthor: use drm_gem_prime_self_import() helper
>   drm/panfrost: use drm_gem_prime_self_import() helper
>   drm/amdgpu: use drm_gem_prime_self_import() helper
> 
>  drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 14 +---
>  drivers/gpu/drm/drm_gem_shmem_helper.c      | 14 ++--
>  drivers/gpu/drm/drm_prime.c                 | 74 +++++++++++++++------
>  drivers/gpu/drm/panfrost/panfrost_gem.c     | 10 +--
>  drivers/gpu/drm/panthor/panthor_gem.c       | 10 +--
>  drivers/gpu/drm/xe/xe_dma_buf.c             | 23 ++++---
>  drivers/gpu/drm/xe/xe_dma_buf.h             |  2 +
>  include/drm/drm_prime.h                     |  8 ++-
>  8 files changed, 91 insertions(+), 64 deletions(-)
> 
> -- 
> 2.43.0
> 

  parent reply	other threads:[~2026-10-13  1:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13  1:06 [PATCH v2 0/6] drm: consolidate self-imported PRIME dma-buf detection Niranjana Vishwanathapura
2026-10-13  1:06 ` [PATCH v2 1/6] drm/gem: add helper to detect self-imported PRIME dma-bufs Niranjana Vishwanathapura
2026-10-13  1:06 ` [PATCH v2 2/6] drm/xe/dma-buf: Use drm helper to detect dma-buf self-import Niranjana Vishwanathapura
2026-10-13  1:06 ` [PATCH v2 3/6] drm/gem: add drm_gem_prime_dma_buf_to_gem() self-import helper Niranjana Vishwanathapura
2026-10-13  1:36   ` Matthew Brost
2026-10-13  7:17     ` Thomas Zimmermann
2026-10-13 18:37       ` Matthew Brost
2026-10-13  1:06 ` [PATCH v2 4/6] drm/panthor: use drm_gem_prime_self_import() helper Niranjana Vishwanathapura
2026-10-13  1:06 ` [PATCH v2 5/6] drm/panfrost: " Niranjana Vishwanathapura
2026-10-13  1:06 ` [PATCH v2 6/6] drm/amdgpu: " Niranjana Vishwanathapura
2026-10-13  1:38 ` Matthew Brost [this message]
2026-10-13  7:17 ` [PATCH v2 0/6] drm: consolidate self-imported PRIME dma-buf detection Thomas Zimmermann
2026-10-13 18:29   ` Niranjana Vishwanathapura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=as2Lmp0A5EwH2OC8@gsse-cloud1.jf.intel.com \
    --to=matthew.brost@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=niranjana.vishwanathapura@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox