Re: [PATCH v8 14/15] drm/xe/hwmon: Add CRI PCIe temperature sensor offset

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Tue, Oct 06, 2026 at 09:05:33AM +0530, Karthik Poosa wrote:
> Describe the Crescent Island PCIe temperature sensor at byte offset 20 in
> READ_THERMAL_DATA.
> 
> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_pci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index 1cbd49933b2c..c7ab7b1abd25 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -482,6 +482,7 @@ static const struct xe_device_desc cri_desc = {
>  	.has_i2c = true,
>  	.has_mbx_power_limits = true,
>  	.has_mbx_thermal_info = true,
> +	.pcie_temp_sensor_offset = 20,

wrong place and bad name and it should be squashed to the previous patch.

But also, please disregard the rv-b that I gave there... seeing this again
this is a bad naming... I'm also bad with naming, but pcie_ as a prefix
seems something related to the pci spec itself, what is not the case,
so we need something different....

>  	.has_mert = true,
>  	.has_pre_prod_wa = 1,
>  	.has_soc_remapper_sysctrl = true,
> -- 
> 2.25.1
>