Re: [PATCH] drm/xe/madvise: use already clamped pat_index

[Matthew Brost <matthew.brost@intel.com>]

On Thu, Oct 15, 2026 at 11:34:16AM +0100, Matthew Auld wrote:
> Pass the nospec-clamped pat_index to check_pat_args_are_sane() instead
> of the raw args->pat_index.val, and fold into the preceding
> DRM_XE_MEM_RANGE_ATTR_PAT block.
> 
> Assisted-by: LLM
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://sashiko.dev/#/message/sashiko-outbox-172627%40kernel.org
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
> Cc: Tejas Upadhyay <tejas.upadhyay@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_vm_madvise.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vm_madvise.c b/drivers/gpu/drm/xe/xe_vm_madvise.c
> index 5c7aefc641ee..a835cc55658f 100644
> --- a/drivers/gpu/drm/xe/xe_vm_madvise.c
> +++ b/drivers/gpu/drm/xe/xe_vm_madvise.c
> @@ -659,11 +659,8 @@ int xe_vm_madvise_ioctl(struct drm_device *dev, void *data, struct drm_file *fil
>  			err = -EINVAL;
>  			goto free_vmas;
>  		}
> -	}
>  
> -	if (args->type == DRM_XE_MEM_RANGE_ATTR_PAT) {
> -		if (!check_pat_args_are_sane(xe, &madvise_range,
> -					     args->pat_index.val)) {
> +		if (!check_pat_args_are_sane(xe, &madvise_range, pat_index)) {
>  			err = -EINVAL;
>  			goto free_vmas;
>  		}
> -- 
> 2.56.0
>