From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75FF0606A31A for ; Tue, 27 Oct 2026 01:29:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=HFBGqHoe Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2667710E089; Tue, 27 Oct 2026 01:29:27 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6E30B10E089 for ; Tue, 27 Oct 2026 01:29:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793064561; x=1824600561; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jA0C820IRe4dqcWGorXsmIbL//FioSOpSQPQ7Nf7sjc=; b=HFBGqHoeZTPGFN7a0aeuevoemSU3c5OrDCg+CHWXeMLYXU98y9U1SyPI QJSXo5J9Wm2i/Dn+q3kp2PKmbECyjD65VSYOHrS8FqKQ22S9cSWj3jPSi Ok1ikoFO/6Cy+itInj3mfWoIMf83MtYEJjwewkk/jDgKGZ3Kw07fYFlPw u0k4WJjk47wZiVFeb9OddH/QUuw40mAwgYFeCt+qtlxYlfdNApo0Gk/TH JR8wSWgp312kaCH0dt0e9hZCv5MUpXaZUdn1TJFP27bu5O4iv6V6dq6Qp xtt4YSp3bCeM69OHRuZMMlktBoSocOZgvzMgCzEjrZpqacobAbzLHGXQb g==; X-CSE-ConnectionGUID: SPHMpF+wRi6onnF5/M29sw== X-CSE-MsgGUID: g4V+idntR7m25l+AyAGIZQ== X-IronPort-AV: E=McAfee;i="6800,10657,11947"; a="1641162" X-IronPort-AV: E=Sophos;i="6.27,180,1787036400"; d="scan'208";a="1641162" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2026 18:29:20 -0700 X-CSE-ConnectionGUID: ThDE3jfqQgO5+XLtPATAPA== X-CSE-MsgGUID: AhnKLyDcSp+kei5VHFzqOw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,180,1787036400"; d="scan'208";a="4802133" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa006.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2026 18:29:18 -0700 Date: Tue, 27 Oct 2026 02:29:15 +0100 From: Raag Jadav To: "Nilawar, Badal" Cc: intel-xe@lists.freedesktop.org, anshuman.gupta@intel.com, rodrigo.vivi@intel.com, daniele.ceraolospurio@intel.com, riana.tauro@intel.com, mallesh.koujalagi@intel.com, aravind.iddamsetty@intel.com, himal.prasad.ghimiray@intel.com, arvind.yadav@intel.com, syed.abdul.muqthyar.ahmed@intel.com, nitin.r.gote@intel.com Subject: Re: [PATCH v5 07/13] drm/xe/xe_ras: Report device memory errors using SIGID Message-ID: References: <20261023043422.681260-15-badal.nilawar@intel.com> <20261023043422.681260-22-badal.nilawar@intel.com> <508a5fd5-5734-4eba-b93c-b247a6418476@intel.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <508a5fd5-5734-4eba-b93c-b247a6418476@intel.com> X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Intel-xe" X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Tue, Oct 27, 2026 at 12:01:42AM +0530, Nilawar, Badal wrote: > On 26-10-2026 18:17, Raag Jadav wrote: > > On Fri, Oct 23, 2026 at 10:04:29AM +0530, Badal Nilawar wrote: > > > Use xe_log_comp_info helper to report device memory errors using the > > > corresponding SIGID. > > > > > > Example: > > > xe 0000:03:00.0: [drm] SIGID=202 (020100020008002000300000) > > > DEVICE_MEMORY: Double-bit ECC error detected at sw address 0x63000 > > > > > > Reviewed-by: Mallesh Koujalagi > > > Signed-off-by: Badal Nilawar > > > Cc: Riana Tauro > > > --- > > > v5: > > > - Log unknown memory errors > > > - Add example log in commit message (Raag) > > > --- > > > drivers/gpu/drm/xe/xe_ras.c | 20 +++++++++++++++++--- > > > 1 file changed, 17 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/xe/xe_ras.c b/drivers/gpu/drm/xe/xe_ras.c > > > index 95e87c635b04..5ebfc6e8dfc7 100644 > > > --- a/drivers/gpu/drm/xe/xe_ras.c > > > +++ b/drivers/gpu/drm/xe/xe_ras.c > > > @@ -643,6 +643,7 @@ static u8 handle_soc_internal_errors(struct xe_device *xe, struct xe_ras_error_a > > > static u8 handle_device_memory_errors(struct xe_device *xe, struct xe_ras_error_array *arr) > > > { > > > struct xe_ras_memory_error *info = (void *)arr->details; > > > + u8 cper_sev = ras_sev_to_cper_sev(arr->counter.common.severity); > > > int ret; > > > /* > > > @@ -654,17 +655,30 @@ static u8 handle_device_memory_errors(struct xe_device *xe, struct xe_ras_error_ > > > */ > > > switch (info->category) { > > > case XE_RAS_MEMORY_POISON: > > > - xe_info(xe, "[RAS]: Poison error detected\n"); > > > + xe_log_comp_info(xe, DEVICE_MEMORY, &arr->counter, sizeof(arr->counter), > > > + "Poison error detected\n"); > > > break; > > > case XE_RAS_MEMORY_DATA_PARITY: > > > - xe_info(xe, "[RAS]: Data parity error detected\n"); > > > + xe_log_comp_info(xe, DEVICE_MEMORY, &arr->counter, sizeof(arr->counter), > > > + "Data parity error detected\n"); > > > break; > > > case XE_RAS_MEMORY_DB_ECC: > > > ret = handle_page_offline(xe, info->sw_address, true); > > > - if (ret) > > > + if (ret) { > > > + xe_log_comp(xe, cper_sev, DEVICE_MEMORY, > > > + &arr->counter, sizeof(arr->counter), > > > + "Failed to recover double-bit ECC error at sw address 0x%llx\n", > > > + info->sw_address); > > Isn't handle_page_offline() already logging this? If no, shouldn't we > > try to consolidate? > > It doesn't emit CPER. So perhaps convert them into cper instead of duplicating logs? Raag