From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7E6B606A320 for ; Thu, 29 Oct 2026 18:59:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=iDLLrMwh Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6067510E823; Thu, 29 Oct 2026 18:59:17 +0000 (UTC) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0D1231124F0 for ; Thu, 29 Oct 2026 18:59:11 +0000 (UTC) Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4a5087a5348so23598365e9.0 for ; Thu, 29 Oct 2026 11:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793300349; x=1793905149; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=K0Ytmrnk1GXIgM1fqIrHZ5HsCVM2IH42icX0Nl0p4uM=; b=iDLLrMwhESqkTZ7HmkWs3YmOMgMO2C+W3wgNBfIeHBYqV3+ceyIObRhqks0qcVjwc7 A1IfNUFlM+jVR9B/LXbVrncGVbL17EY0kxQ2jFmH2RqQznxWNASdea+lkf5GLcJjQD3r F7Pn6zKPES4M8bXaRLulH2zftAmKvi2qNE198kH9zS9VgIJe36iD3U1+yeMkGa9JVwHP ST27E5j2pfq8V+kuLqeQ0R3IO4GEPfFrx1bAYl1WbmVqHjg7J7K3VByyNtwpCkyW8qln amAtnt5Mk/qVNAqnzzZ/5dLsztza6yQZpKqIGRd2ax/jls8oR3OmQWc1DkQ5yhpXc1I6 DLTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793300349; x=1793905149; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=K0Ytmrnk1GXIgM1fqIrHZ5HsCVM2IH42icX0Nl0p4uM=; b=GGq/bj4qrfFhC6KbRg7cjmDXejQ86Aask8/KDA2Tiett4yZmYisR2/neRpKLyrkAWB +KaZ7RpPOXDPsJa01SDrLX/duBfShfrTbsexbpHzQKd8lojvCh/O7pQD8rCbUvtqqckh 2188MdXHwVmotakcDejxhXtw6rAc/rq7C7jj4rkdPSk+5nzw3qR4ctDJ1lShxYBt5Ns1 kez0wfVP7CFE7/+eT4Nls8jusSE2Ck4cKe2Q/BzgWRONS4uX+c/ETE5DKGzFd5NPNnP8 5I7cok5uEf6NIMLVDpuq/A8cRU8kGba397bgf17SOrbP+T5LGBr/1K++m234R4GnRGcw ff2w== X-Forwarded-Encrypted: i=1; AKwUvBztIUekGAVhUWfx6nSztEoGtSuKX71QNqLZr4p2wVKB0NINGpAamwj7Ru+mbRH38L5a3H126UwCGQ==@lists.freedesktop.org X-Gm-Message-State: AFq9FYImT3GfMFYaa08yR07GdRa2hiuuVBjuK6mUCc8XyZ16SbzkpcA9 MGfm+XmZaW75PMYhr2MnzRA4lUMPvsraQOUGGkSm8e3gv8Cl++CP+KN5 X-Gm-Gg: AYBFou1K1Mdt3oRQPtsyMOmz5MCvwk33cE9DLX5aY03RAt5JxDnQwQldFUJCX7ioSvn yreWhNNz0rYuAmrBiUWW3T31tY4WOru1IFX0p0nDlcO0OOoSfve7ZUstPcMv9Z1wqHt29RN5CaJ TedQgVs8gFQY4xXS3iSGMUEwMIFMHi/O4+a9nQrzm/I9G7bfDYxhPjJ/0iWuGTtiOhH7b1t3+NF Q2+JS3TaMYjEYJYP/3DBFedFwgtav5JgRyL/BOQcPvn8MXBnWm/S/DtJUFfUELYh1nW5+HDnkdI s4zDVYazx86BrM2o2ipB+ETAzWHWvh1ERGmQII/QZOlu9olvSF/IZy6kfUEZaYnX6JENSjdAHvh kMS6mSVHGR2OJ380cuYDAlisLRcx5theXa/Tb+i918AwNSUUN6l7P4HmKyOvlrGR1FZdDvsDsxv je3nItRMznMG/xfOm+qOBcaVNoRiFKhEc/HJTEnnqkm35zvl7vaNr55fDwImrcmZ9wTJzaZ+AHy FHfjYxTOeOv1RlOBgmGZXCHjcsBdnwbeIzx9K1kKjctJmEpqexqe11vOd9smHG3JeL9GokRDH8r dbBgCfxB9cY5o9cW9cYmfhE5DScIzAE3LzWq+d0Eyg0h+FHcd9ZjoPZ1Dqn7OcLh05o/ncUY8VH vUWACIfVqOGWa3hz8A2oR7jm+k957ttURyQjtau3IMGLthFUd8JrxfMYNk3u/9tLjz0OMUrCDSx HnH3RUpIeT5uU8 X-Received: by 2002:a05:600d:4121:b0:4a3:59c9:a758 with SMTP id 5b1f17b1804b1-4a96836988amr152798385e9.32.1793300349381; Thu, 29 Oct 2026 11:59:09 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4abf6c76507sm4933955e9.10.2026.10.29.11.59.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2026 11:59:08 -0700 (PDT) Date: Thu, 29 Oct 2026 21:59:04 +0300 From: Dan Carpenter To: Frank.Li@oss.nxp.com Cc: Frank Li , "Rafael J. Wysocki" , Greg Kroah-Hartman , Andrzej Kacprowski , Karol Wachowski , Oded Gabbay , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Matthew Brost , Thomas Hellstrom , David Airlie , Simona Vetter , Alex Elder , Will Deacon , Robin Murphy , Joerg Roedel , Rob Clark , Sakari Ailus , Mauro Carvalho Chehab , Guenter Roeck , Guan-Yu Lin , Mathias Nyman , linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, netdev@vger.kernel.org, imx@lists.linux.dev, Rob Herring Subject: Re: [PATCH 1/1] PM: runtime: change stub pm_runtime_get_if_active() return 1 when !CONFIG_PM Message-ID: References: <20261029163044.3062958-1-Frank.Li@oss.nxp.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261029163044.3062958-1-Frank.Li@oss.nxp.com> X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Intel-xe" X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Thu, Oct 29, 2026 at 12:30:37PM -0400, Frank.Li@oss.nxp.com wrote: > Pattern C: ret > 0 / ret <= 0 / ret != 1 checks -- FIXED > drivers/usb/core/offload.c: checks (!= 1), old -EINVAL caused > -EBUSY even with !CONFIG_PM. Fixed: now returns 1, proceeds. > drivers/accel/ivpu/ivpu_job.c: drm_WARN_ON(<= 0), old -EINVAL > spuriously triggered WARN. Fixed: 1 > 0, no warn. > drivers/gpu/drm/i915/intel_runtime_pm.c: checks (<= 0), old > -EINVAL triggered error path. Fixed: 1 > 0, correct path. > drivers/accel/ivpu/ivpu_sysfs.c: (> 0), old skipped freq read. > Fixed: proceeds correctly without CONFIG_PM. > drivers/gpu/drm/xe/xe_pm.c: wraps (> 0), all xe callers > (xe_bo.c, xe_shrinker.c, xe_vsec.c, xe_ggtt.c, xe_guc_ct.c, > xe_pxp.c) now correctly treat !CONFIG_PM as active. > drivers/net/ipa/ipa_smp2p.c: power_on = (> 0), now correctly true. > drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c: (> 0), now correctly > executes stall register update. > drivers/staging/media/ipu7/ipu7-buttress.c: active (<= 0) early > return now skipped, correctly proceeds. Pattern C is mostly bugs so this patch should have a Fixes tag since it fixes bugs. regards, dan carpenter