Re: [PATCH 2/2] drm/xe: Annotate default for guc_log_level param

[John Harrison <john.c.harrison@intel.com>]

On 6/12/2025 11:05 AM, Lucas De Marchi wrote:
> Reword the parameter description so it's clear what's the default and
> what are the verbose levels.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>

> ---
>   drivers/gpu/drm/xe/xe_module.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_module.c b/drivers/gpu/drm/xe/xe_module.c
> index 4809afa7ce3f9..3ca25bea5a15a 100644
> --- a/drivers/gpu/drm/xe/xe_module.c
> +++ b/drivers/gpu/drm/xe/xe_module.c
> @@ -43,7 +43,11 @@ module_param_named(vram_bar_size, xe_modparam.force_vram_bar_size, int, 0600);
>   MODULE_PARM_DESC(vram_bar_size, "Set the vram bar size (in MiB) - <0=disable-resize, 0=max-needed-size[default], >0=force-size");
>   
>   module_param_named(guc_log_level, xe_modparam.guc_log_level, int, 0600);
> -MODULE_PARM_DESC(guc_log_level, "GuC firmware logging level (0=disable, 1..5=enable with verbosity min..max)");
> +#if IS_ENABLED(CONFIG_DRM_XE_DEBUG)
> +MODULE_PARM_DESC(guc_log_level, "GuC firmware logging level (0=disable, 1=normal, 2..5=verbose-levels [default=3])");
> +#else
> +MODULE_PARM_DESC(guc_log_level, "GuC firmware logging level (0=disable, 1=normal, 2..5=verbose-levels [default=1])");
> +#endif
>   
>   module_param_named_unsafe(guc_firmware_path, xe_modparam.guc_firmware_path, charp, 0400);
>   MODULE_PARM_DESC(guc_firmware_path,
>