Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Poosa, Karthik" <karthik.poosa@intel.com>
To: Mohammed Thasleem <mohammed.thasleem@intel.com>,
	<intel-xe@lists.freedesktop.org>
Cc: <anshuman.gupta@intel.com>
Subject: Re: [PATCH] drm/xe/xe_debugfs: Expose G7 package state residency counter through debugfs
Date: Thu, 16 Oct 2025 09:36:46 +0530	[thread overview]
Message-ID: <b4100879-4704-40d3-bc58-3933a060f963@intel.com> (raw)
In-Reply-To: <20251016001219.37684-1-mohammed.thasleem@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1544 bytes --]


On 16-10-2025 05:42, Mohammed Thasleem wrote:
> Add G7 package state residency counter in debugfs alongside existing
> G2,G6,G8,G10 states for complete power state visibility.
>
> Signed-off-by: Mohammed Thasleem<mohammed.thasleem@intel.com>
> ---
>   drivers/gpu/drm/xe/regs/xe_pmt.h | 1 +
>   drivers/gpu/drm/xe/xe_debugfs.c  | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/regs/xe_pmt.h b/drivers/gpu/drm/xe/regs/xe_pmt.h
> index 264e9baf949c..0f79c0714454 100644
> --- a/drivers/gpu/drm/xe/regs/xe_pmt.h
> +++ b/drivers/gpu/drm/xe/regs/xe_pmt.h
> @@ -24,6 +24,7 @@
>   #define BMG_MODS_RESIDENCY_OFFSET		(0x4D0)
>   #define BMG_G2_RESIDENCY_OFFSET		(0x530)
>   #define BMG_G6_RESIDENCY_OFFSET		(0x538)
> +#define BMG_G7_RESIDENCY_OFFSET		(0x4B0)
>   #define BMG_G8_RESIDENCY_OFFSET		(0x540)
>   #define BMG_G10_RESIDENCY_OFFSET		(0x548)
>   
> diff --git a/drivers/gpu/drm/xe/xe_debugfs.c b/drivers/gpu/drm/xe/xe_debugfs.c
> index d67e32ebbe29..417e6df95e1c 100644
> --- a/drivers/gpu/drm/xe/xe_debugfs.c
> +++ b/drivers/gpu/drm/xe/xe_debugfs.c
> @@ -142,6 +142,7 @@ static int dgfx_pkg_residencies_show(struct seq_file *m, void *data)
>   	} residencies[] = {
>   		{BMG_G2_RESIDENCY_OFFSET, "Package G2"},
>   		{BMG_G6_RESIDENCY_OFFSET, "Package G6"},
> +		{BMG_G7_RESIDENCY_OFFSET, "Package G7"},
>   		{BMG_G8_RESIDENCY_OFFSET, "Package G8"},
>   		{BMG_G10_RESIDENCY_OFFSET, "Package G10"},
>   		{BMG_MODS_RESIDENCY_OFFSET, "Package ModS"}

LGTM.
Reviewed-by: Karthik Poosa <karthik.poosa@intel.com>


[-- Attachment #2: Type: text/html, Size: 2105 bytes --]

  reply	other threads:[~2025-10-16  4:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16  0:12 [PATCH] drm/xe/xe_debugfs: Expose G7 package state residency counter through debugfs Mohammed Thasleem
2025-10-16  4:06 ` Poosa, Karthik [this message]
2025-10-16  4:12 ` ✓ CI.KUnit: success for " Patchwork
2025-10-16  5:06 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-16 22:38 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4100879-4704-40d3-bc58-3933a060f963@intel.com \
    --to=karthik.poosa@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=mohammed.thasleem@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox