From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEC17C52D7C for ; Fri, 9 Aug 2024 10:46:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 729EB10E8A8; Fri, 9 Aug 2024 10:46:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="mf/t3MLr"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id BE0E110E8A8; Fri, 9 Aug 2024 10:46:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723200366; x=1754736366; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=C/bEpF3uJUy0adiwUzePhmER0/b3YSDURgaN+lGaPgw=; b=mf/t3MLr5lKq3gytICRirK7ZLFz2Y6uqFbariUO38AM6N3kYMjUUTtqB PfB7pXQJpGS5ARXjvjbggk1lPMIguVE6fXzJ9RnxL3xYxzYrMxP8itHZa o4q61EpQpV/moPxWkGJAA+C9E2u6bSnFodjFCBZpbrib5VYYXSbNZ57k2 gzWq7DPvZmF65mxdEIruZ0kQDOB0iXWeCq/fuvxmucQmVZeNsee8/aQ52 rz7/w9UTaLx15u3VNPWMJMZBU7QHqwaOEjt8XAEQrz2PLLyzXrXTnm5g5 IudM5dbQ2O/s0KXWPRggwfkdkoFmsKABuQN+RTqlsdO+weCC/rOw/3cy1 A==; X-CSE-ConnectionGUID: qOC/t0aHQlSr8kG7nn01wg== X-CSE-MsgGUID: hr8///uWRAqEG1a7rqnSRA== X-IronPort-AV: E=McAfee;i="6700,10204,11158"; a="38875382" X-IronPort-AV: E=Sophos;i="6.09,276,1716274800"; d="scan'208";a="38875382" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2024 03:46:05 -0700 X-CSE-ConnectionGUID: vb79Ctc9Qgydlze82YicKA== X-CSE-MsgGUID: +E39iGpAS8O3hPOxy/3z8A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,276,1716274800"; d="scan'208";a="80768750" Received: from apaszkie-mobl2.apaszkie-mobl2 (HELO [10.245.245.147]) ([10.245.245.147]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2024 03:46:04 -0700 Message-ID: Date: Fri, 9 Aug 2024 11:46:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/3] drm/xe/migrate: Parameterize ccs and bo data clear in xe_migrate_clear() To: Nirmoy Das , dri-devel@lists.freedesktop.org Cc: intel-xe@lists.freedesktop.org, Himal Prasad Ghimiray , Matthew Brost , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Akshata Jahagirdar References: <20240719095506.4068-1-nirmoy.das@intel.com> <20240719095506.4068-2-nirmoy.das@intel.com> Content-Language: en-GB From: Matthew Auld In-Reply-To: <20240719095506.4068-2-nirmoy.das@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On 19/07/2024 10:55, Nirmoy Das wrote: > Parameterize clearing ccs and bo data in xe_migrate_clear() which higher > layers can utilize. This patch will be used later on when doing bo data > clear for igfx as well. > > v2: Replace multiple params with flags in xe_migrate_clear (Matt B) > v3: s/CLEAR_BO_DATA_FLAG_*/XE_MIGRATE_CLEAR_FLAG_* and move to > xe_migrate.h. other nits(Matt B) > > Cc: Himal Prasad Ghimiray > Cc: Matthew Auld > Cc: Matthew Brost > Cc: "Thomas Hellström" > Signed-off-by: Nirmoy Das > Signed-off-by: Akshata Jahagirdar Seems reasonable to me, Reviewed-by: Matthew Auld