Re: [PATCH 1/2] drm/i915/scaler: Use intel_display as argument to skl_scaler_max_src_size

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 7/8/2025 10:03 AM, Suraj Kandpal wrote:
> skl_scaler_max_src_size has really no use of intel_crtc other than
> deriving intel_display. Let's just pass intel_display to it directly.
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>


> ---
>   drivers/gpu/drm/i915/display/skl_scaler.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c
> index d77798499c57..a6ba9da03542 100644
> --- a/drivers/gpu/drm/i915/display/skl_scaler.c
> +++ b/drivers/gpu/drm/i915/display/skl_scaler.c
> @@ -91,11 +91,9 @@ static void skl_scaler_min_src_size(const struct drm_format_info *format,
>   	}
>   }
>   
> -static void skl_scaler_max_src_size(struct intel_crtc *crtc,
> +static void skl_scaler_max_src_size(struct intel_display *display,
>   				    int *max_w, int *max_h)
>   {
> -	struct intel_display *display = to_intel_display(crtc);
> -
>   	if (DISPLAY_VER(display) >= 14) {
>   		*max_w = 4096;
>   		*max_h = 8192;
> @@ -201,7 +199,7 @@ skl_update_scaler(struct intel_crtc_state *crtc_state, bool force_detach,
>   	}
>   
>   	skl_scaler_min_src_size(format, modifier, &min_src_w, &min_src_h);
> -	skl_scaler_max_src_size(crtc, &max_src_w, &max_src_h);
> +	skl_scaler_max_src_size(display, &max_src_w, &max_src_h);
>   
>   	skl_scaler_min_dst_size(&min_dst_w, &min_dst_h);
>   	skl_scaler_max_dst_size(crtc, &max_dst_w, &max_dst_h);