Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Almahallawy, Khaled" <khaled.almahallawy@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"Taylor,  Clinton A" <clinton.a.taylor@intel.com>,
	"ddavenport@google.com" <ddavenport@google.com>
Subject: Re: drm/i915/display: HDMI C10 PLL entry for 265250 MHz
Date: Wed, 15 Jan 2025 23:41:04 +0000	[thread overview]
Message-ID: <ba160c734f0bd0d5d9fafe639465ab61a5302ec6.camel@intel.com> (raw)
In-Reply-To: <20250115230859.2410966-1-clinton.a.taylor@intel.com>

Thank You for the patch

Without this patch on monitors that support this mode like Acer x34 and
LG 34GS95QE. this resolution is rejected as follow:

[drm:drm_mode_prune_invalid] Rejected mode: "3440x1440": 50 265250 3440
3488 3520 3600 1440 1443 1453 1474 0x48 0x9 (CLOCK_RANGE)

With this patch, we are able to drive this resolution and pixel clock:

 pipe mode: "3440x1440": 50 265250 3440 3488 3520 3600 1440 1443 1453
1474 0x40 0x9

Tested-by: Khaled Almahallawy <khaled.almahallawy@intel.com> 

On Wed, 2025-01-15 at 15:08 -0800, Clint Taylor wrote:
> Add PLL values for 265.250MHz pixel clock to support recent 3440x1440
> monitors.
> 
> Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_cx0_phy.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> index e768dc6a15b3..c5ea8202a455 100644
> --- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> @@ -1620,6 +1620,16 @@ static const struct intel_c10pll_state
> mtl_c10_hdmi_262750 = {
>  	.pll[15] = 0x09, .pll[16] = 0x09, .pll[17] = 0xCF, .pll[18]
> = 0x84, .pll[19] = 0x23,
>  };
>  
> +static const struct intel_c10pll_state mtl_c10_hdmi_265250 = {
> +	.clock = 265250,
> +	.tx = 0x10,
> +	.cmn = 0x1,
> +	.pll[0] = 0xF4, .pll[1] = 0x00, .pll[2] = 0x6A, .pll[3] =
> 0x00, .pll[4] = 0x00,
> +	.pll[5] = 0x00, .pll[6] = 0x00, .pll[7] = 0x00, .pll[8] =
> 0x20, .pll[9] = 0xFF,
> +	.pll[10] = 0xFF, .pll[11] = 0x55, .pll[12] = 0x13, .pll[13]
> = 0x55, .pll[14] = 0x55,
> +	.pll[15] = 0x09, .pll[16] = 0x08, .pll[17] = 0x0F, .pll[18]
> = 0x85, .pll[19] = 0x23,
> +};
> +
>  static const struct intel_c10pll_state mtl_c10_hdmi_268500 = {
>  	.clock = 268500,
>  	.tx = 0x10,
> @@ -1728,6 +1738,7 @@ static const struct intel_c10pll_state * const
> mtl_c10_hdmi_tables[] = {
>  	&mtl_c10_hdmi_209800,
>  	&mtl_c10_hdmi_241500,
>  	&mtl_c10_hdmi_262750,
> +	&mtl_c10_hdmi_265250,
>  	&mtl_c10_hdmi_268500,
>  	&mtl_c10_hdmi_296703,
>  	&mtl_c10_hdmi_297000,


  reply	other threads:[~2025-01-15 23:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-15 23:08 [PATCH] drm/i915/display: HDMI C10 PLL entry for 265250 MHz Clint Taylor
2025-01-15 23:41 ` Almahallawy, Khaled [this message]
2025-01-16  4:51   ` Nautiyal, Ankit K
2025-01-15 23:46 ` ✓ CI.Patch_applied: success for " Patchwork
2025-01-15 23:46 ` ✓ CI.checkpatch: " Patchwork
2025-01-15 23:47 ` ✓ CI.KUnit: " Patchwork
2025-01-16  0:05 ` ✓ CI.Build: " Patchwork
2025-01-16  0:08 ` ✓ CI.Hooks: " Patchwork
2025-01-16  0:09 ` ✓ CI.checksparse: " Patchwork
2025-01-16  0:35 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-16  3:48 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba160c734f0bd0d5d9fafe639465ab61a5302ec6.camel@intel.com \
    --to=khaled.almahallawy@intel.com \
    --cc=clinton.a.taylor@intel.com \
    --cc=ddavenport@google.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox