public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>,
	<intel-xe@lists.freedesktop.org>
Cc: Gustavo Sousa <gustavo.sousa@intel.com>
Subject: Re: [PATCH] drm/xe/xe3p: Disable GuC Dynamic ICS for Xe3p
Date: Wed, 21 Jan 2026 13:06:58 -0800	[thread overview]
Message-ID: <bb14af79-4553-43f0-b7a0-fac2e7f943c1@intel.com> (raw)
In-Reply-To: <20260121143732.523081-2-balasubramani.vivekanandan@intel.com>



On 1/21/2026 6:37 AM, Balasubramani Vivekanandan wrote:
> From: Gustavo Sousa <gustavo.sousa@intel.com>
>
> The Dynamic Inhibit Context Switch (ICS) feature is not currently
> supported on Xe3p due to conflict with multi-queue feature on the GuC
> side. Disable ICS so multi-queue can be introduced for Xe3p platforms.
>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
> Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_guc.c | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
> index 44360437beeb..e350ded92544 100644
> --- a/drivers/gpu/drm/xe/xe_guc.c
> +++ b/drivers/gpu/drm/xe/xe_guc.c
> @@ -608,6 +608,13 @@ static bool supports_dynamic_ics(struct xe_guc *guc)
>   	if (xe_gt_is_media_type(gt) || gt->ccs_mode > 1)
>   		return false;
>   
> +	/*
> +	 * The feature is currently not compatible with platforms with support
> +	 * to multi-queue, even if the feature is not enabled/used.
> +	 */
> +	if (GRAPHICS_VER(xe) >= 35)
> +		return false;

This has been fixed in GuC 70.50.0, so this check shouldn't be 
necessary. Are you seeing any issue with that GuC version or newer?

Daniele

> +
>   	/*
>   	 * Dynamic ICS requires GuC v70.40.1, which maps to compatibility
>   	 * version v1.18.4.


  parent reply	other threads:[~2026-01-21 21:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21 14:37 [PATCH] drm/xe/xe3p: Disable GuC Dynamic ICS for Xe3p Balasubramani Vivekanandan
2026-01-21 14:42 ` ✓ CI.KUnit: success for " Patchwork
2026-01-21 15:18 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-21 21:06 ` Daniele Ceraolo Spurio [this message]
2026-01-22 13:27   ` [PATCH] " Vivekanandan, Balasubramani
2026-01-21 23:12 ` ✓ Xe.CI.Full: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb14af79-4553-43f0-b7a0-fac2e7f943c1@intel.com \
    --to=daniele.ceraolospurio@intel.com \
    --cc=balasubramani.vivekanandan@intel.com \
    --cc=gustavo.sousa@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox