Re: [PATCH v4 3/3] drm/xe/xe_guc_submit: Declare reset if banned or killed

["Summers, Stuart" <stuart.summers@intel.com>]

On Fri, 2024-04-05 at 10:55 -0700, Jonathan Cavitt wrote:
> Add an additional condition to the reset_status guc_exec_queue_op
> that
> returns true if the exec queue has been banned or killed.  The
> reset_status op is only used for exiting any xe_wait_user_fence_ioctl
> that waits on an exec queue without timing out, so doing this will
> exit
> the ioctl early in cases where the exec queue can no longer function,
> such as after a GuC stop during a reset.
> 
> Suggested-by: Matthew Brost <matthew.brost@intel.com>
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>

Makes sense.

Reviewed-by: Stuart Summers <stuart.summers@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c
> b/drivers/gpu/drm/xe/xe_guc_submit.c
> index e72f2a6cad60a..d5182f66177f1 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -1371,7 +1371,7 @@ static void guc_exec_queue_resume(struct
> xe_exec_queue *q)
>  
>  static bool guc_exec_queue_reset_status(struct xe_exec_queue *q)
>  {
> -       return exec_queue_reset(q);
> +       return exec_queue_reset(q) || exec_queue_killed_or_banned(q);
>  }
>  
>  /*