Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yadav, Sanjay Kumar" <sanjay.kumar.yadav@intel.com>
To: Matthew Auld <matthew.auld@intel.com>, <intel-xe@lists.freedesktop.org>
Cc: Ulisses Furquim <ulisses.furquim@intel.com>
Subject: Re: [PATCH v2] drm/xe/uapi: update used tracking kernel-doc
Date: Fri, 30 Jan 2026 21:58:24 +0530	[thread overview]
Message-ID: <bb7e21c8-8fb3-4081-8a64-ddef60bc48ed@intel.com> (raw)
In-Reply-To: <20260130125105.451229-2-matthew.auld@intel.com>


On 30-01-2026 18:21, Matthew Auld wrote:
> In commit 4d0b035fd6da ("drm/xe/uapi: loosen used tracking restriction")
> we dropped the CAP_PERMON restriction but missed updating the
> corresponding kernel-doc. Fix that.
>
> v2 (Sanjay):
>    - Don't drop the note around the extra cpu_visible_used expectations.
>
> Reported-by: Ulisses Furquim <ulisses.furquim@intel.com>
> Fixes: 4d0b035fd6da ("drm/xe/uapi: loosen used tracking restriction")
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Sanjay Yadav <sanjay.kumar.yadav@intel.com>

Reviewed-by: Sanjay Yadav <sanjay.kumar.yadav@intel.com>

LGTM

> ---
>   include/uapi/drm/xe_drm.h | 8 +-------
>   1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
> index 077e66a682e2..c9e70f78e723 100644
> --- a/include/uapi/drm/xe_drm.h
> +++ b/include/uapi/drm/xe_drm.h
> @@ -335,10 +335,6 @@ struct drm_xe_mem_region {
>   	__u64 total_size;
>   	/**
>   	 * @used: Estimate of the memory used in bytes for this region.
> -	 *
> -	 * Requires CAP_PERFMON or CAP_SYS_ADMIN to get reliable
> -	 * accounting.  Without this the value here will always equal
> -	 * zero.
>   	 */
>   	__u64 used;
>   	/**
> @@ -363,9 +359,7 @@ struct drm_xe_mem_region {
>   	 * @cpu_visible_used: Estimate of CPU visible memory used, in
>   	 * bytes.
>   	 *
> -	 * Requires CAP_PERFMON or CAP_SYS_ADMIN to get reliable
> -	 * accounting. Without this the value here will always equal
> -	 * zero.  Note this is only currently tracked for
> +	 * Note this is only currently tracked for
>   	 * DRM_XE_MEM_REGION_CLASS_VRAM regions (for other types the value
>   	 * here will always be zero).
>   	 */

      parent reply	other threads:[~2026-01-30 16:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-30 12:51 [PATCH v2] drm/xe/uapi: update used tracking kernel-doc Matthew Auld
2026-01-30 12:56 ` ✗ CI.checkpatch: warning for drm/xe/uapi: update used tracking kernel-doc (rev2) Patchwork
2026-01-30 12:58 ` ✓ CI.KUnit: success " Patchwork
2026-01-30 13:35 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-30 16:28 ` Yadav, Sanjay Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb7e21c8-8fb3-4081-8a64-ddef60bc48ed@intel.com \
    --to=sanjay.kumar.yadav@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    --cc=ulisses.furquim@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox