From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Kandpal, Suraj" <suraj.kandpal@intel.com>,
"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "Murthy, Arun R" <arun.r.murthy@intel.com>
Subject: RE: [PATCH v3 1/8] drm/i915/backlight: Use default/max brightness for VESA AUX backlight init
Date: Wed, 04 Mar 2026 14:06:30 +0200 [thread overview]
Message-ID: <bc588898a98e512b60e209324495e747cd003364@intel.com> (raw)
In-Reply-To: <DM3PPF208195D8DE8AD240BD7C41488F465E37CA@DM3PPF208195D8D.namprd11.prod.outlook.com>
On Wed, 04 Mar 2026, "Kandpal, Suraj" <suraj.kandpal@intel.com> wrote:
> I did some more digging and for aux_set enabled we really do not need to do get_backlight
> And read register again that is filled in probe state and fills up the current_level variable that can be use.
> Check drm_edp_backlight_probe_state.
> I also found this little comment there
>
> /*
> * If we're not in DPCD control mode yet, the programmed brightness value is meaningless and
> * the driver should assume max brightness
> */
> return bl->max;
>
> So this was a policy that was decided during VESA AUX Backlight implementation time. Also that Mode will not be DPCD
> Initially and will change later during backlight enable so we get to assume max brightness . That should be okay to do with
> Luminance_set case too then.
The comment says, if the panel is not in DPCD control mode, the value in
DPCD is meaningless.
Ditto, if the panel is not in luminance control mode (or whatever the
specific name for it is), the luminance value in DPCD is meaningless.
However, if the panel is in DPCD control mode but not in luminance
control mode, we should be able to read the non-luminance DPCD
brightness value and use that.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-03-04 12:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 3:45 [PATCH v3 0/8] Fixes and updates when using AUX backlight using Luminance Suraj Kandpal
2026-02-24 3:45 ` [PATCH v3 1/8] drm/i915/backlight: Use default/max brightness for VESA AUX backlight init Suraj Kandpal
2026-02-24 12:31 ` Jani Nikula
2026-02-25 4:43 ` Kandpal, Suraj
2026-03-02 9:42 ` Jani Nikula
2026-03-02 10:00 ` Kandpal, Suraj
2026-03-02 10:28 ` Jani Nikula
2026-03-02 11:04 ` Kandpal, Suraj
2026-03-02 11:25 ` Jani Nikula
2026-03-04 5:49 ` Kandpal, Suraj
2026-03-04 12:06 ` Jani Nikula [this message]
2026-02-24 3:45 ` [PATCH v3 2/8] drm/i915/backlight: Use intel_panel variable instead of intel_connector Suraj Kandpal
2026-02-24 3:45 ` [PATCH v3 3/8] drm/i915/backlight: Take luminance_set into account for VESA backlight Suraj Kandpal
2026-02-24 3:45 ` [PATCH v3 4/8] drm/i915/backlight: Check luminance_set when disabling PWM via AUX " Suraj Kandpal
2026-02-24 3:45 ` [PATCH v3 5/8] drm/i915/backlight: Short circuit intel_dp_aux_supports_hdr_backlight Suraj Kandpal
2026-02-24 3:45 ` [PATCH v3 6/8] drm/i915/backlight: Update debug log during backlight setup Suraj Kandpal
2026-02-24 3:45 ` [PATCH v3 7/8] drm/i915/backlight: Provide clear description on how backlight level is controlled Suraj Kandpal
2026-02-24 3:45 ` [PATCH v3 8/8] drm/i915/backlight: Use default/max brightness for INTEL AUX HDR backlight init Suraj Kandpal
2026-02-24 12:32 ` Jani Nikula
2026-02-24 3:54 ` ✓ CI.KUnit: success for Fixes and updates when using AUX backlight using Luminance (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc588898a98e512b60e209324495e747cd003364@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=arun.r.murthy@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=suraj.kandpal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox