Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"Manna,  Animesh" <animesh.manna@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Cc: "Nikula, Jani" <jani.nikula@intel.com>, "B, Jeevan" <jeevan.b@intel.com>
Subject: Re: [PATCH v6 3/8] drm/i915/lobf: Add fixed refresh rate check in compute_config()
Date: Mon, 24 Mar 2025 08:00:27 +0000	[thread overview]
Message-ID: <bd0d6aa54f473a34ddacae1eadcdb2d4543444f9.camel@intel.com> (raw)
In-Reply-To: <20250319191508.2751216-4-animesh.manna@intel.com>

On Thu, 2025-03-20 at 00:45 +0530, Animesh Manna wrote:
> LOBF can be enabled with vrr fixed rate mode, so add check
> if vmin = vmax = flipline in compute_config().
> 
> Signed-off-by: Animesh Manna <animesh.manna@intel.com>

Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_alpm.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c
> b/drivers/gpu/drm/i915/display/intel_alpm.c
> index d2f133bc5f38..c2862888466f 100644
> --- a/drivers/gpu/drm/i915/display/intel_alpm.c
> +++ b/drivers/gpu/drm/i915/display/intel_alpm.c
> @@ -288,6 +288,10 @@ void intel_alpm_lobf_compute_config(struct
> intel_dp *intel_dp,
>  	if (crtc_state->has_psr)
>  		return;
>  
> +	if (crtc_state->vrr.vmin != crtc_state->vrr.vmax ||
> +	    crtc_state->vrr.vmin != crtc_state->vrr.flipline)
> +		return;
> +
>  	if (!(intel_alpm_aux_wake_supported(intel_dp) ||
>  	      intel_alpm_aux_less_wake_supported(intel_dp)))
>  		return;


  reply	other threads:[~2025-03-24  8:01 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-19 19:15 [PATCH v6 0/8] LOBF enablement fix Animesh Manna
2025-03-19 19:15 ` [PATCH v6 1/8] drm/i915/lobf: Add lobf enablement in post plane update Animesh Manna
2025-03-24  7:59   ` Hogander, Jouni
2025-03-19 19:15 ` [PATCH v6 2/8] drm/i915/lobf: Disintegrate alpm_disable from psr_disable Animesh Manna
2025-03-19 19:15 ` [PATCH v6 3/8] drm/i915/lobf: Add fixed refresh rate check in compute_config() Animesh Manna
2025-03-24  8:00   ` Hogander, Jouni [this message]
2025-03-19 19:15 ` [PATCH v6 4/8] drm/i915/lobf: Update lobf if any change in dependent parameters Animesh Manna
2025-03-24  8:05   ` Hogander, Jouni
2025-03-27 10:43     ` Manna, Animesh
2025-03-27 11:00       ` Hogander, Jouni
2025-03-19 19:15 ` [PATCH v6 5/8] drm/i915/lobf: Add debug interface for lobf Animesh Manna
2025-03-24  8:07   ` Hogander, Jouni
2025-03-27 10:44     ` Manna, Animesh
2025-03-24  8:35   ` Jani Nikula
2025-03-19 19:15 ` [PATCH v6 6/8] drm/i915/lobf: Check for sink error and disable LOBF Animesh Manna
2025-03-24  7:53   ` Hogander, Jouni
2025-03-27 10:54     ` Manna, Animesh
2025-03-19 19:15 ` [PATCH v6 7/8] drm/i915/lobf: Add mutex for alpm update Animesh Manna
2025-03-24  7:56   ` Hogander, Jouni
2025-03-19 19:15 ` [PATCH v6 8/8] drm/i915/lobf: Add debug print for LOBF Animesh Manna
2025-03-24  7:59   ` Hogander, Jouni
2025-03-27 10:55     ` Manna, Animesh
2025-03-19 19:42 ` ✓ CI.Patch_applied: success for LOBF enablement fix (rev5) Patchwork
2025-03-19 19:42 ` ✗ CI.checkpatch: warning " Patchwork
2025-03-19 19:43 ` ✓ CI.KUnit: success " Patchwork
2025-03-19 20:00 ` ✓ CI.Build: " Patchwork
2025-03-19 20:02 ` ✓ CI.Hooks: " Patchwork
2025-03-19 20:03 ` ✗ CI.checksparse: warning " Patchwork
2025-03-19 20:25 ` ✓ Xe.CI.BAT: success " Patchwork
2025-03-19 21:21 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd0d6aa54f473a34ddacae1eadcdb2d4543444f9.camel@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jeevan.b@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox