Re: [PATCH v5 02/14] drm/xe/xe_sysctrl: Make sysctrl flood limit reusable

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

Hi Riana,

On 11-05-2026 10:59 pm, Riana Tauro wrote:
> The sysctrl command flood limit was defined in an event specific header,
> restricting its usage to event handling. Move it to the shared header
> with a generic name so it can be re-used across all files
> using system controller commands.
>
> Signed-off-by: Riana Tauro <riana.tauro@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_sysctrl_event.c         | 2 +-
>   drivers/gpu/drm/xe/xe_sysctrl_event_types.h   | 2 +-
>   drivers/gpu/drm/xe/xe_sysctrl_mailbox_types.h | 3 +++
>   3 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_sysctrl_event.c b/drivers/gpu/drm/xe/xe_sysctrl_event.c
> index b4d17329af6c..faf6ba89ce98 100644
> --- a/drivers/gpu/drm/xe/xe_sysctrl_event.c
> +++ b/drivers/gpu/drm/xe/xe_sysctrl_event.c
> @@ -16,7 +16,7 @@ static void get_pending_event(struct xe_sysctrl *sc, struct xe_sysctrl_mailbox_c
>   {
>   	struct xe_sysctrl_event_response *response = command->data_out;
>   	struct xe_device *xe = sc_to_xe(sc);
> -	u32 count = XE_SYSCTRL_EVENT_FLOOD;
> +	u32 count = XE_SYSCTRL_FLOOD;
>   	size_t len;
>   	int ret;
>   
> diff --git a/drivers/gpu/drm/xe/xe_sysctrl_event_types.h b/drivers/gpu/drm/xe/xe_sysctrl_event_types.h
> index c16c66b9fa7f..d236e22fe9dd 100644
> --- a/drivers/gpu/drm/xe/xe_sysctrl_event_types.h
> +++ b/drivers/gpu/drm/xe/xe_sysctrl_event_types.h
> @@ -11,7 +11,7 @@
>   #define XE_SYSCTRL_EVENT_DATA_LEN		59
>   
>   /* Modify as needed */
> -#define XE_SYSCTRL_EVENT_FLOOD			16
> +#define XE_SYSCTRL_FLOOD			16
>   
>   /**
>    * enum xe_sysctrl_event - Events reported by System Controller
> diff --git a/drivers/gpu/drm/xe/xe_sysctrl_mailbox_types.h b/drivers/gpu/drm/xe/xe_sysctrl_mailbox_types.h
> index 84d7c647e743..0fa786a9e8c8 100644
> --- a/drivers/gpu/drm/xe/xe_sysctrl_mailbox_types.h
> +++ b/drivers/gpu/drm/xe/xe_sysctrl_mailbox_types.h
> @@ -48,6 +48,9 @@ struct xe_sysctrl_mailbox_command {
>   	size_t data_out_len;
>   };
>   
> +/* Modify as needed */
> +#define XE_SYSCTRL_FLOOD			16

The XE_SYSCTRL_FLOOD definition appears in two files. This is like keeping
two copies of the same information - if we need to change it later, we might
forget to update both places and cause problems. Let's move it to one shared
location so there's only one place to maintain it.

Thanks,
-/Mallesh

> +
>   #define XE_SYSCTRL_MB_FRAME_SIZE	16
>   #define XE_SYSCTRL_MB_MAX_FRAMES	64
>   #define XE_SYSCTRL_MB_MAX_MESSAGE_SIZE	\