Re: [PATCH 0/5] GuC Buffer Cache

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 12.10.2024 04:02, Matthew Brost wrote:
> On Wed, Oct 09, 2024 at 07:21:20PM +0200, Michal Wajdeczko wrote:
>> Michal Wajdeczko (5):
>>   drm/xe/guc: Introduce the GuC Buffer Cache
>>   drm/xe/kunit: Allow to replace xe_managed_bo_create_pin_map()
>>   drm/xe/kunit: Add KUnit tests for GuC Buffer Cache
>>   drm/xe/pf: Prepare GuC Buffer Cache for PF-only actions
>>   drm/xe/pf: Use GuC Buffer Cache during VFs provisioning
>>
>>  drivers/gpu/drm/xe/Makefile                 |   1 +
>>  drivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c | 450 ++++++++++++++++++++
>>  drivers/gpu/drm/xe/xe_bo.c                  |   4 +
>>  drivers/gpu/drm/xe/xe_gt.c                  |   6 +
>>  drivers/gpu/drm/xe/xe_gt_sriov_pf.c         |  32 ++
>>  drivers/gpu/drm/xe/xe_gt_sriov_pf.h         |   6 +
>>  drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c  |  67 +--
>>  drivers/gpu/drm/xe/xe_gt_sriov_pf_types.h   |   4 +
>>  drivers/gpu/drm/xe/xe_guc_buf.c             | 391 +++++++++++++++++
>>  drivers/gpu/drm/xe/xe_guc_buf.h             |  48 +++
>>  drivers/gpu/drm/xe/xe_guc_buf_types.h       |  40 ++
>>  11 files changed, 1017 insertions(+), 32 deletions(-)
> 
> See my comment in patch #1, please explore if that suggestion works.

already tried but it didn't work, hence this new code

> Nearly 1000+ new lines code needs to be carefully considered if this is
> required. IMO we really want avoid bloating Xe unless this has strong
> justification.

my bad, I missed to refer to [1] where it was pointed that PF should
avoid doing any memory allocations during resume/reset and with this new
cache in patch 5/5 PF is now able to do VFs re-provisioning (which uses
H2G CTB with indirect data) without any allocations

[1]
https://lore.kernel.org/intel-xe/3e13401972fd49240f486fd7d47580e576794c78.camel@intel.com/

> 
> Matt
> 
>>  create mode 100644 drivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c
>>  create mode 100644 drivers/gpu/drm/xe/xe_guc_buf.c
>>  create mode 100644 drivers/gpu/drm/xe/xe_guc_buf.h
>>  create mode 100644 drivers/gpu/drm/xe/xe_guc_buf_types.h
>>
>> -- 
>> 2.43.0
>>