Re: [PATCH v2 1/3] drm/xe: Always kill exec queues in xe_guc_submit_pause_abort

["Summers, Stuart" <stuart.summers@intel.com>]

On Thu, 2025-12-18 at 13:44 -0800, Matthew Brost wrote:
> xe_guc_submit_pause_abort is intended to be called after something
> disastrous occurs (e.g., VF migration fails, device wedging, or

I don't know if I'd qualify driver unload as disastrous, but otherwise
agree :)

Reviewed-by: Stuart Summers <stuart.summers@intel.com>

> driver
> unload) and should immediately trigger the teardown of remaining
> submission state. With that, kill any remaining queues in this
> function.
> 
> Fixes: 7c4b7e34c83b ("drm/xe/vf: Abort VF post migration recovery on
> failure")
> Cc: stable@vger.kernel.org
> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c
> b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 43fd2069f9b2..071cbfec2401 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -2890,8 +2890,7 @@ void xe_guc_submit_pause_abort(struct xe_guc
> *guc)
>                         continue;
>  
>                 xe_sched_submission_start(sched);
> -               if (exec_queue_killed_or_banned_or_wedged(q))
> -                       xe_guc_exec_queue_trigger_cleanup(q);
> +               guc_exec_queue_kill(q);
>         }
>         mutex_unlock(&guc->submission_state.lock);
>  }