Re: [PATCH 01/13] drm/xe/irq: Always free requested IRQs on uninstall

["Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>]

On 27-08-2026 15:47, Arvind Yadav wrote:
> xe_irq_suspend() clears irq.enabled after disabling and synchronizing the
> interrupts. irq_uninstall() currently returns when that flag is clear, so
> a suspended device can skip free_irq() during teardown.
> 
> The managed uninstall action is registered only after the IRQ request
> succeeds. Reset the interrupt registers only when interrupts are still
> enabled, but always free the requested IRQs.
> 
> Fixes: 4d79a1266d4c ("drm/xe: Make irq enabled flag atomic")

Fixes seems incorrect, the early return was even before the change.

> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Assisted-by: Claude:claude-opus-4-8
> Signed-off-by: Arvind Yadav <arvind.yadav@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_irq.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
> index 9e49e2241da4..d314993b14a1 100644
> --- a/drivers/gpu/drm/xe/xe_irq.c
> +++ b/drivers/gpu/drm/xe/xe_irq.c
> @@ -786,10 +786,8 @@ static void irq_uninstall(void *arg)
>   {
>   	struct xe_device *xe = arg;
>   
> -	if (!atomic_xchg(&xe->irq.enabled, 0))
> -		return;
> -
> -	xe_irq_reset(xe);
> +	if (atomic_xchg(&xe->irq.enabled, 0))
> +		xe_irq_reset(xe);

Patch looks correct. With correct fixes-tag:

Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>


>   
>   	if (xe_device_has_msix(xe))
>   		xe_irq_msix_free(xe);