Re: [PATCH v5 2/5] drm/xe/vf: Revert logic of vf.migration.enabled

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 10/21/2025 2:39 PM, Tomasz Lis wrote:
> Convert `enabled` property into `disabled`.
> 
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Signed-off-by: Tomasz Lis <tomasz.lis@intel.com>
> Suggested-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_sriov_vf.c       | 6 +++---
>  drivers/gpu/drm/xe/xe_sriov_vf_types.h | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_sriov_vf.c b/drivers/gpu/drm/xe/xe_sriov_vf.c
> index 911d5720917b..5ad39e315cb5 100644
> --- a/drivers/gpu/drm/xe/xe_sriov_vf.c
> +++ b/drivers/gpu/drm/xe/xe_sriov_vf.c
> @@ -130,7 +130,7 @@
>  bool xe_sriov_vf_migration_supported(struct xe_device *xe)
>  {
>  	xe_assert(xe, IS_SRIOV_VF(xe));
> -	return xe->sriov.vf.migration.enabled;
> +	return !xe->sriov.vf.migration.disabled;
>  }
>  
>  static void vf_disable_migration(struct xe_device *xe, const char *fmt, ...)
> @@ -146,7 +146,7 @@ static void vf_disable_migration(struct xe_device *xe, const char *fmt, ...)
>  	xe_sriov_notice(xe, "migration disabled: %pV\n", &vaf);
>  	va_end(va_args);
>  
> -	xe->sriov.vf.migration.enabled = false;
> +	xe->sriov.vf.migration.disabled = true;
>  }
>  
>  static void vf_migration_init_early(struct xe_device *xe)
> @@ -173,7 +173,7 @@ static void vf_migration_init_early(struct xe_device *xe)
>  						    guc_version.major, guc_version.minor);
>  	}
>  
> -	xe->sriov.vf.migration.enabled = true;
> +	xe->sriov.vf.migration.disabled = false;

this should be just removed (it's false by default)
>  	xe_sriov_dbg(xe, "migration support enabled\n");

and we already agreed that we will just log the "disabled" case
so this line should go away too

>  }
>  
> diff --git a/drivers/gpu/drm/xe/xe_sriov_vf_types.h b/drivers/gpu/drm/xe/xe_sriov_vf_types.h
> index 6a0fd0f5463e..d5f72d667817 100644
> --- a/drivers/gpu/drm/xe/xe_sriov_vf_types.h
> +++ b/drivers/gpu/drm/xe/xe_sriov_vf_types.h
> @@ -34,10 +34,10 @@ struct xe_device_vf {
>  	/** @migration: VF Migration state data */
>  	struct {
>  		/**
> -		 * @migration.enabled: flag indicating if migration support
> -		 * was enabled or not due to missing prerequisites
> +		 * @migration.disabled: flag indicating if migration support
> +		 * was turned off due to missing prerequisites
>  		 */
> -		bool enabled;
> +		bool disabled;
>  	} migration;
>  
>  	/** @ccs: VF CCS state data */